[scanner] fix: add missing loading states on async actions#19417
Conversation
kubestellar-prow
Bot
added
the
dco-signoff: yes
✅ Deploy Preview for kubestellarconsole ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubestellar-prow
Bot
added
the
size/M
|
👋 Hey @clubanderson — thanks for opening this PR!
This is an automated message. |
|
🐝 Hi @clubanderson! I'm Trusted users — org members and contributors with write access — can mention Automation may take a moment to start, and follow-up happens through workflow activity rather than chat replies. |
Auto Test GeneratorThe following new files have no corresponding test file:
Please add tests or apply the |
✅ Test Coverage CheckAll new source files in this PR have corresponding test files. Checked |
There was a problem hiding this comment.
Pull request overview
This PR addresses missing UX feedback on async actions by adding loading indicators and disabling action buttons while requests are in-flight, reducing the chance of duplicate submissions and improving perceived responsiveness.
Changes:
- Add loading/disabled state handling for “Add member” and “Remove member” flows in
TeamMemberManager. - Add loading/disabled state handling for OPA policy mode toggling and policy deletion actions in
ClusterOPAModal.
Note: build/lint are validated by CI on the PR for this repository.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| web/src/components/teams/TeamMemberManager.tsx | Adds isAdding/isRemoving state and wires loading/disabled UI to add/remove member actions. |
| web/src/components/cards/opa/ClusterOPAModal.tsx | Adds per-action loading state for toggle-mode and delete flows, including spinners and disabled buttons. |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Add loading/disabled states to async action buttons that were missing user feedback during operations: - ClusterOPAModal: disable toggle-mode button with spinner while patching enforcement action; disable delete button with spinner while deleting policy - TeamMemberManager: disable Add Member button with loading spinner while adding; pass isLoading to ConfirmDialog while removing member Fixes #19409 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Copilot <copilot@github.com>
The className prop had a syntax error with the exclamation mark outside the string quotes. This caused the frontend build to fail. Signed-off-by: GitHub Copilot <copilot@github.com> Signed-off-by: Copilot <copilot@github.com>
kubestellar-hive
Bot
force-pushed
the
scanner/fix-19409
branch
from
38646ab to
76981b3
Compare
Signed-off-by: clubanderson <club.anderson@gmail.com>
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
✅ Post-Merge Verification: passedCommit: |
|
Post-merge build verification passed ✅ Both Go and frontend builds compiled successfully against merge commit |
Fixes #19409
Adds loading indicators and disabled states to async action buttons that were missing feedback during operations:
isLoadingtoConfirmDialogwhile removing a member