🐛 Fix Go vet errors by upgrading addon-framework#162
🐛 Fix Go vet errors by upgrading addon-framework#162kubestellar-prow[bot] merged 1 commit intomainfrom
Conversation
Fixes undefined: utilversion.NewEffectiveVersion error caused by version mismatch between addon-framework v1.0.1 and k8s v0.34.1. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
Welcome to KubeStellar! 🚀 Thank you for submitting this Pull Request. Before your PR can be merged, please ensure: ✅ DCO Sign-off - All commits must be signed off with ✅ PR Title - Must start with an emoji: ✨ (feature), 🐛 (bug fix), 📖 (docs), 🌱 (infra/tests), Getting Started with KubeStellar: Contributor Resources:
🌟 Help KubeStellar Grow - We Need Adopters! Our roadmap is driven entirely by adopter feedback. Whether you're using KubeStellar yourself or know someone who could benefit from multi-cluster Kubernetes: 📋 Take our Multi-Cluster Survey - Share your use cases and help shape our direction! A maintainer will review your PR soon. Feel free to ask questions in the comments or on Slack! |
There was a problem hiding this comment.
Pull request overview
This PR upgrades the addon-framework dependency to resolve Go vet compilation errors caused by an undefined function in the previous version.
Changes:
- Upgraded
open-cluster-management.io/addon-frameworkfrom v1.0.1 to v1.1.2 - Updated transitive dependencies to maintain compatibility with k8s v0.34.1
Comments suppressed due to low confidence (1)
go.mod:3
- Go version 1.24.5 does not exist. As of January 2025, the latest Go version is 1.23.x. This appears to be a future or invalid version number.
go 1.24.5
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/lgtm |
|
/approve |
|
@clubanderson: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: clubanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
🎉 Thank you for your contribution! Your PR has been successfully merged. 🌟 Help KubeStellar Grow - We Need Adopters! Our roadmap is driven entirely by adopter feedback - nothing else. Whether you're using KubeStellar yourself or know organizations that could benefit from multi-cluster Kubernetes, we need your help: 📋 Take our Multi-Cluster Survey - Share your use cases and help shape our direction! 🗣️ Spread the word - Tell colleagues, write blog posts, present at meetups 💬 Share feedback on Slack #kubestellar-dev Every adopter story helps us prioritize what matters most. Thank you for being part of the KubeStellar community! |
Summary
Fixes CI failure caused by Go vet errors.
Problem
Solution
Upgrade
open-cluster-management.io/addon-frameworkfrom v1.0.1 to v1.1.2, which is compatible with k8s v0.34.1.🤖 Generated with Claude Code