Skip to content

🐛 Fix Go vet errors by upgrading addon-framework#162

Merged
kubestellar-prow[bot] merged 1 commit intomainfrom
fix-go-vet-errors
Jan 15, 2026
Merged

🐛 Fix Go vet errors by upgrading addon-framework#162
kubestellar-prow[bot] merged 1 commit intomainfrom
fix-go-vet-errors

Conversation

@clubanderson
Copy link
Copy Markdown
Contributor

Summary

Fixes CI failure caused by Go vet errors.

Problem

# open-cluster-management.io/addon-framework/pkg/cmd/factory
undefined: utilversion.NewEffectiveVersion
make: *** [Makefile:121: vet] Error 1

Solution

Upgrade open-cluster-management.io/addon-framework from v1.0.1 to v1.1.2, which is compatible with k8s v0.34.1.

🤖 Generated with Claude Code

Fixes undefined: utilversion.NewEffectiveVersion error caused by
version mismatch between addon-framework v1.0.1 and k8s v0.34.1.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Copilot AI review requested due to automatic review settings January 15, 2026 00:29
@kubestellar-prow kubestellar-prow bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Jan 15, 2026
@github-actions
Copy link
Copy Markdown

Welcome to KubeStellar! 🚀 Thank you for submitting this Pull Request.

Before your PR can be merged, please ensure:

DCO Sign-off - All commits must be signed off with git commit -s to certify the Developer Certificate of Origin

PR Title - Must start with an emoji: ✨ (feature), 🐛 (bug fix), 📖 (docs), 🌱 (infra/tests), ⚠️ (breaking change)

Getting Started with KubeStellar:

Contributor Resources:


🌟 Help KubeStellar Grow - We Need Adopters!

Our roadmap is driven entirely by adopter feedback. Whether you're using KubeStellar yourself or know someone who could benefit from multi-cluster Kubernetes:

📋 Take our Multi-Cluster Survey - Share your use cases and help shape our direction!


A maintainer will review your PR soon. Feel free to ask questions in the comments or on Slack!

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the addon-framework dependency to resolve Go vet compilation errors caused by an undefined function in the previous version.

Changes:

  • Upgraded open-cluster-management.io/addon-framework from v1.0.1 to v1.1.2
  • Updated transitive dependencies to maintain compatibility with k8s v0.34.1
Comments suppressed due to low confidence (1)

go.mod:3

  • Go version 1.24.5 does not exist. As of January 2025, the latest Go version is 1.23.x. This appears to be a future or invalid version number.
go 1.24.5

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kubestellar-prow kubestellar-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 15, 2026
@clubanderson
Copy link
Copy Markdown
Contributor Author

/lgtm

@clubanderson
Copy link
Copy Markdown
Contributor Author

/approve

@kubestellar-prow
Copy link
Copy Markdown
Contributor

@clubanderson: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@clubanderson clubanderson added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Jan 15, 2026
@kubestellar-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: clubanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow bot merged commit 4c388e5 into main Jan 15, 2026
15 checks passed
@kubestellar-prow kubestellar-prow bot deleted the fix-go-vet-errors branch January 15, 2026 00:56
@github-actions
Copy link
Copy Markdown

🎉 Thank you for your contribution! Your PR has been successfully merged.


🌟 Help KubeStellar Grow - We Need Adopters!

Our roadmap is driven entirely by adopter feedback - nothing else. Whether you're using KubeStellar yourself or know organizations that could benefit from multi-cluster Kubernetes, we need your help:

📋 Take our Multi-Cluster Survey - Share your use cases and help shape our direction!

🗣️ Spread the word - Tell colleagues, write blog posts, present at meetups

💬 Share feedback on Slack #kubestellar-dev

Every adopter story helps us prioritize what matters most. Thank you for being part of the KubeStellar community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants