🌱 Sync workflows from kubestellar/infra#172
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Welcome to KubeStellar! 🚀 Thank you for submitting this Pull Request. Before your PR can be merged, please ensure: ✅ DCO Sign-off - All commits must be signed off with ✅ PR Title - Must start with an emoji: ✨ (feature), 🐛 (bug fix), 📖 (docs), 🌱 (infra/tests), Getting Started with KubeStellar: Contributor Resources:
🌟 Help KubeStellar Grow - We Need Adopters! Our roadmap is driven entirely by adopter feedback. Whether you're using KubeStellar yourself or know someone who could benefit from multi-cluster Kubernetes: 📋 Take our Multi-Cluster Survey - Share your use cases and help shape our direction! A maintainer will review your PR soon. Feel free to ask questions in the comments or on Slack! |
There was a problem hiding this comment.
Pull request overview
This PR syncs two new Copilot-related workflow files from the kubestellar/infra repository. These workflows integrate GitHub Copilot automation for issue fixing and PR processing, expanding the existing set of automated workflows that already call reusable workflows from kubestellar/infra.
Changes:
- Added
copilot-automation.ymlworkflow to automate Copilot PR processing with DCO and label management - Added
ai-fix.ymlworkflow to assign Copilot to issues with theai-fix-requestedlabel
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .github/workflows/copilot-automation.yml | New workflow to automate Copilot PR processing, triggered by pull_request_target events and manual dispatch |
| .github/workflows/ai-fix.yml | New workflow to integrate Copilot for AI-driven issue fixes, triggered by issue labels, PR opens, and manual dispatch |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ai-fix: | ||
| uses: kubestellar/infra/.github/workflows/reusable-ai-fix.yml@main | ||
| with: | ||
| issue_number: ${{ github.event.inputs.issue_number || '' }} |
There was a problem hiding this comment.
When this workflow is triggered by issues events (lines 10-11) or pull_request_target events (lines 12-13), the issue_number parameter will be empty because github.event.inputs.issue_number is only populated for workflow_dispatch events. The expression should also include github.event.issue.number for issue events and potentially github.event.pull_request.number for PR events. Consider using: issue_number: ${{ github.event.issue.number || github.event.pull_request.number || github.event.inputs.issue_number || '' }}
| issue_number: ${{ github.event.inputs.issue_number || '' }} | |
| issue_number: ${{ github.event.issue.number || github.event.pull_request.number || github.event.inputs.issue_number || '' }} |
| secrets: | ||
| token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
This workflow uses an explicit token secret instead of secrets: inherit which is the pattern used by all other workflows in this repository that call reusable workflows from kubestellar/infra. Consider changing to use secrets: inherit for consistency with other workflows like add-help-wanted.yml, greetings.yml, pr-verifier.yml, and stale.yml.
| secrets: | ||
| token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
This workflow uses an explicit token secret instead of secrets: inherit which is the pattern used by all other workflows in this repository that call reusable workflows from kubestellar/infra. Consider changing to use secrets: inherit for consistency with other workflows like add-help-wanted.yml, greetings.yml, pr-verifier.yml, and stale.yml.
| copilot-automation: | ||
| uses: kubestellar/infra/.github/workflows/reusable-copilot-automation.yml@main | ||
| with: | ||
| pr_number: ${{ github.event.inputs.pr_number || '' }} |
There was a problem hiding this comment.
When this workflow is triggered by pull_request_target events (lines 10-11), the pr_number parameter will be empty because github.event.inputs.pr_number is only populated for workflow_dispatch events. The expression should also include github.event.pull_request.number to correctly pass the PR number for pull_request_target events. Consider using: pr_number: ${{ github.event.pull_request.number || github.event.inputs.pr_number || '' }}
| pr_number: ${{ github.event.inputs.pr_number || '' }} | |
| pr_number: ${{ github.event.pull_request.number || github.event.inputs.pr_number || '' }} |
|
🎉 Thank you for your contribution! Your PR has been successfully merged. 🌟 Help KubeStellar Grow - We Need Adopters! Our roadmap is driven entirely by adopter feedback - nothing else. Whether you're using KubeStellar yourself or know organizations that could benefit from multi-cluster Kubernetes, we need your help: 📋 Take our Multi-Cluster Survey - Share your use cases and help shape our direction! 🗣️ Spread the word - Tell colleagues, write blog posts, present at meetups 💬 Share feedback on Slack #kubestellar-dev Every adopter story helps us prioritize what matters most. Thank you for being part of the KubeStellar community! |
This PR syncs the caller workflows from
kubestellar/infra.These workflows call reusable workflows from
kubestellar/infra:Standard Workflows:
add-help-wanted.yml- Add help-wanted label to issuesassignment-helper.yml- Handle issue assignmentsfeedback.yml- Collect feedbackgreetings.yml- Welcome new contributorslabel-helper.yml- Manage labelspr-verifier.yml- Verify PR contentspr-verify-title.yml- Verify PR title formatscorecard.yml- Security scorecardstale.yml- Mark stale issues/PRsAgentic Workflows (Copilot Integration):
ai-fix.yml- Assign Copilot to issues withai-fix-requestedlabelcopilot-automation.yml- Automate Copilot PR processing (DCO, labels)copilot-dco.yml- Override DCO for Copilot PRsAuto-generated by workflow sync