Skip to content

🐛fix: migrate Drupal Helm chart to OCI registry #2416

Open
sarafarajnasardi wants to merge 1 commit intokubestellar:devfrom
sarafarajnasardi:2128
Open

🐛fix: migrate Drupal Helm chart to OCI registry #2416
sarafarajnasardi wants to merge 1 commit intokubestellar:devfrom
sarafarajnasardi:2128

Conversation

@sarafarajnasardi
Copy link
Copy Markdown

Description

Resolves connectivity issues with Bitnami repository by migrating to OCI registry. Implements helm pull CLI approach for OCI chart support.

Changes:

  • Frontend: Updated to use oci://registry-1.docker.io/bitnamicharts
  • Backend: Added OCI chart pulling via helm CLI command
  • Backend: Enhanced error handling for repository connection issues

Related Issue

Fixes #2128

Changes Made

  • Updated ...
  • Refactored ...
  • Fixed ...
  • Added tests for ...

Checklist

Please ensure the following before submitting your PR:

  • I have reviewed the project's contribution guidelines.
  • I have written unit tests for the changes (if applicable).
  • I have updated the documentation (if applicable).
  • I have tested the changes locally and ensured they work as expected.
  • My code follows the project's coding standards.

Screenshots or Logs (if applicable)

Screencast.From.2026-02-08.17-02-10.mp4

Resolves connectivity issues with Bitnami repository by migrating to
OCI registry. Implements helm pull CLI approach for OCI chart support.

Changes:
- Frontend: Updated to use oci://registry-1.docker.io/bitnamicharts
- Backend: Added OCI chart pulling via helm CLI command
- Backend: Enhanced error handling for repository connection issues
- Docker: Fixed kubeconfig mount for kubectl context switching

Tested: Successfully deployed drupal-23.0.0 with proper workload labels

Signed-off-by: Sarafaraj Nasardi <sarafarajnasardi786@gmail.com>
@kubestellar-prow kubestellar-prow bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Feb 8, 2026
@kubestellar-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign antedotee for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 8, 2026

Welcome to KubeStellar! 🚀 Thank you for submitting this Pull Request.

Before your PR can be merged, please ensure:

DCO Sign-off - All commits must be signed off with git commit -s to certify the Developer Certificate of Origin

PR Title - Must start with an emoji: ✨ (feature), 🐛 (bug fix), 📖 (docs), 🌱 (infra/tests), ⚠️ (breaking change)

Getting Started with KubeStellar:

Contributor Resources:


🌟 Help KubeStellar Grow - We Need Adopters!

Our roadmap is driven entirely by adopter feedback. Whether you're using KubeStellar yourself or know someone who could benefit from multi-cluster Kubernetes:

📋 Take our Multi-Cluster Survey - Share your use cases and help shape our direction!


A maintainer will review your PR soon. Feel free to ask questions in the comments or on Slack!

@kubestellar-prow
Copy link
Copy Markdown

Hi @sarafarajnasardi. Thanks for your PR.

I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubestellar-prow kubestellar-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 8, 2026
@github-actions github-actions bot added backend Issues or PRs related to the low-level API machinery for KubeStellar frontend other docker and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 8, 2026
Copy link
Copy Markdown
Contributor

@clubanderson clubanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Critical: Syntax error in Dashboard.tsx

Around lines 853-861, there are duplicate object properties from a broken ternary operator — orphaned bg, text, icon properties outside an object literal. This won't compile.

// Looks like:
? {
    bg: isDark ? 'bg-blue-900/30' : 'bg-blue-100',
    text: isDark ? 'text-blue-400' : 'text-blue-600',
    icon: <Server size={16} />,
  }
    bg: ...   // ← orphaned, outside object
    text: ... // ← orphaned
    icon: ... // ← orphaned
  }

Please fix the ternary so only one set of properties is inside the object.

🟠 Potential infinite render loop in TreeViewComponent.tsx

The new useEffect (line ~182-189) has edges in its dependency array and calls updateEdgeStyles(edges) which internally calls setEdges(). This creates a circular dependency: edges change → effect runs → setEdges → edges change → loop.

Fix: Remove edges from the dependency array. The theme ref guard helps, but won't prevent loops from other edge updates.

🟡 Missing useCallback dependency

In useTreeViewData.ts, updateEdgeStyles useCallback is missing setEdges in its dependency array. Add it: [updateEdgeStylesFromHook, setEdges].

@github-project-automation github-project-automation bot moved this from In Progress to Changes Required in KubeStellar UI Project Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Issues or PRs related to the low-level API machinery for KubeStellar dco-signoff: yes Indicates the PR's author has signed the DCO. docker frontend other

Projects

Status: Changes Required

Development

Successfully merging this pull request may close these issues.

[Bug]: can't deploy helm chart (drupal)

2 participants