🐛fix: migrate Drupal Helm chart to OCI registry #2416
🐛fix: migrate Drupal Helm chart to OCI registry #2416sarafarajnasardi wants to merge 1 commit intokubestellar:devfrom
Conversation
Resolves connectivity issues with Bitnami repository by migrating to OCI registry. Implements helm pull CLI approach for OCI chart support. Changes: - Frontend: Updated to use oci://registry-1.docker.io/bitnamicharts - Backend: Added OCI chart pulling via helm CLI command - Backend: Enhanced error handling for repository connection issues - Docker: Fixed kubeconfig mount for kubectl context switching Tested: Successfully deployed drupal-23.0.0 with proper workload labels Signed-off-by: Sarafaraj Nasardi <sarafarajnasardi786@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome to KubeStellar! 🚀 Thank you for submitting this Pull Request. Before your PR can be merged, please ensure: ✅ DCO Sign-off - All commits must be signed off with ✅ PR Title - Must start with an emoji: ✨ (feature), 🐛 (bug fix), 📖 (docs), 🌱 (infra/tests), Getting Started with KubeStellar: Contributor Resources:
🌟 Help KubeStellar Grow - We Need Adopters! Our roadmap is driven entirely by adopter feedback. Whether you're using KubeStellar yourself or know someone who could benefit from multi-cluster Kubernetes: 📋 Take our Multi-Cluster Survey - Share your use cases and help shape our direction! A maintainer will review your PR soon. Feel free to ask questions in the comments or on Slack! |
|
Hi @sarafarajnasardi. Thanks for your PR. I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
clubanderson
left a comment
There was a problem hiding this comment.
🔴 Critical: Syntax error in Dashboard.tsx
Around lines 853-861, there are duplicate object properties from a broken ternary operator — orphaned bg, text, icon properties outside an object literal. This won't compile.
// Looks like:
? {
bg: isDark ? 'bg-blue-900/30' : 'bg-blue-100',
text: isDark ? 'text-blue-400' : 'text-blue-600',
icon: <Server size={16} />,
}
bg: ... // ← orphaned, outside object
text: ... // ← orphaned
icon: ... // ← orphaned
}Please fix the ternary so only one set of properties is inside the object.
🟠 Potential infinite render loop in TreeViewComponent.tsx
The new useEffect (line ~182-189) has edges in its dependency array and calls updateEdgeStyles(edges) which internally calls setEdges(). This creates a circular dependency: edges change → effect runs → setEdges → edges change → loop.
Fix: Remove edges from the dependency array. The theme ref guard helps, but won't prevent loops from other edge updates.
🟡 Missing useCallback dependency
In useTreeViewData.ts, updateEdgeStyles useCallback is missing setEdges in its dependency array. Add it: [updateEdgeStylesFromHook, setEdges].
Description
Resolves connectivity issues with Bitnami repository by migrating to OCI registry. Implements helm pull CLI approach for OCI chart support.
Changes:
Related Issue
Fixes #2128
Changes Made
Checklist
Please ensure the following before submitting your PR:
Screenshots or Logs (if applicable)
Screencast.From.2026-02-08.17-02-10.mp4