Skip to content

Update README for dev and also lockfile#2446

Open
jschuler wants to merge 2 commits into
kubev2v:mainfrom
jschuler:readme_lockfile
Open

Update README for dev and also lockfile#2446
jschuler wants to merge 2 commits into
kubev2v:mainfrom
jschuler:readme_lockfile

Conversation

@jschuler

@jschuler jschuler commented May 28, 2026

Copy link
Copy Markdown
Contributor

📝 Links

References: None

📝 Description

Improves the local development setup instructions in the README and re-generated the lockfile.
README (Quick Start)

  • Replaces hardcoded placeholder URLs for INVENTORY_SERVER_HOST and SERVICES_API_SERVER_HOST with oc get route commands that read the Forklift inventory and services routes from the openshift-mtv namespace.
  • Bumps the local console image from quay.io/openshift/origin-console:4.19 to 4.22.
    package-lock.json
  • Regenerated from npm install
    Documentation / maintenance only — no application code changes.

🎥 Demo

N/A — documentation and lockfile only; no UI behavior changes.

Summary by CodeRabbit

  • Documentation

    • Updated "Quick Start" setup to derive server host values from OpenShift routes, removing hardcoded example URLs.
  • Chores

    • Bumped console image reference to version 4.22.

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 500375bd-34d7-4f18-9aef-692d931ea8fb

📥 Commits

Reviewing files that changed from the base of the PR and between 0548c0a and 966e9cc.

📒 Files selected for processing (1)
  • README.md
✅ Files skipped from review due to trivial changes (1)
  • README.md

📝 Walkthrough

Walkthrough

Updated the README Quick Start section to dynamically derive OpenShift route endpoints using oc get route commands instead of hardcoded examples, and bumped the console image version from 4.19 to 4.22.

Changes

Quick Start Environment Configuration

Layer / File(s) Summary
OpenShift route integration and console image update
README.md
Environment setup commands now use oc get route to dynamically fetch INVENTORY_SERVER_HOST and SERVICES_API_SERVER_HOST from the cluster; CONSOLE_IMAGE version updated from 4.19 to 4.22.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A hop through the routes so clear,
No more hardcoded hosts to fear,
OpenShift whispers what's where with grace,
Console upgrades set the pace,
Quick starts shine in their place! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title mentions both README and lockfile updates, which aligns with the actual changes, but is somewhat vague about the specific improvements made.
Description check ✅ Passed The description includes all key sections from the template (Links, Description, Demo) and clearly documents the README improvements and lockfile regeneration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Actionable comments posted: 0

@codecov-commenter

codecov-commenter commented Jun 1, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.22%. Comparing base (13484d0) to head (966e9cc).
⚠️ Report is 1099 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2446       +/-   ##
===========================================
- Coverage   36.81%   17.22%   -19.59%     
===========================================
  Files         158     1265     +1107     
  Lines        2548    23620    +21072     
  Branches      599     4507     +3908     
===========================================
+ Hits          938     4069     +3131     
- Misses       1428    19540    +18112     
+ Partials      182       11      -171     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jschuler added 2 commits June 3, 2026 09:06
Use oc get route for inventory/services hosts in Quick Start and bump
local console image to 4.22. Remove unused @emnapi optional deps from lockfile.
Resolves: None

Signed-off-by: Joachim Schuler <jdh.schuler@gmail.com>
Signed-off-by: Joachim Schuler <jdh.schuler@gmail.com>
@avivtur avivtur force-pushed the readme_lockfile branch from 7aea420 to 966e9cc Compare June 3, 2026 06:06
@sonarqubecloud

sonarqubecloud Bot commented Jun 3, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants