MTV-5727: Clarify OCP-to-OCP migration does not require MTV on both clusters#937
Open
nogunix wants to merge 1 commit into
Open
MTV-5727: Clarify OCP-to-OCP migration does not require MTV on both clusters#937nogunix wants to merge 1 commit into
nogunix wants to merge 1 commit into
Conversation
…lusters The CNV prerequisites incorrectly stated that both clusters must have matching MTV versions. The matching-version requirement applies to OpenShift Virtualization, not MTV. MTV only needs to be installed on one cluster, which orchestrates the other via a remote provider.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughPrerequisites documentation for virt cluster migration is updated to require compatible virt versions instead of matching project-first versions, clarify source version requirements (4.16+), and explain that project-first does not require installation on both clusters—it can delegate operations through a remote virt provider. ChangesMigration Prerequisites Clarification
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@documentation/modules/ref_cnv-prerequisites.adoc`:
- Line 10: Add an xref from the sentence mentioning {virt} and {project-short}
in ref_cnv-prerequisites.adoc to the compatibility guidance in
documentation/modules/ref_target-vm-scheduling-prerequisites.adoc (same text
also in proc_configuring-target-vm-scheduling-cli.adoc); update the sentence
that references “your {project-short} version” to include an Asciidoc xref to
the target-vm-scheduling prerequisites page so readers can click through to the
compatibility matrix for {virt} ↔ {project-short} versions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5a8d43b6-2d8d-4f51-9686-312235e01b0d
📒 Files selected for processing (1)
documentation/modules/ref_cnv-prerequisites.adoc
|
|
||
| [role="_abstract"] | ||
| To migrate between {virt} clusters, verify that both clusters have matching {project-first} versions and the source uses {virt} 4.16 or later. You can migrate forward to newer {virt} versions if both are compatible with your {project-short} version. | ||
| To migrate between {virt} clusters, verify that both clusters have compatible {virt} versions and that the source uses {virt} 4.16 or later. You can migrate forward to newer {virt} versions if both are compatible with your {project-short} version. |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Search for {virt} and {project-short} compatibility documentation
# Search for compatibility matrix or version compatibility documentation
rg -i -C3 'compatibility|compatible.*version|version.*compatible' --type=adoc --glob='!ref_cnv-prerequisites.adoc' | head -50
# Search for cross-references to compatibility docs
rg 'xref:.*compatibility|link:.*compatibility' --type=adocRepository: kubev2v/forklift-documentation
Length of output: 132
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Find where {project-short} is defined/used and what it expands to (best-effort via attributes).
rg -n "\{project-short\}" -S .
rg -n "project-short" -S documentation || true
rg -n "attribute::project-short|:project-short:" -S . || true
# Search for compatibility guidance between {virt} and {project-short} (supported/supported on/etc.).
rg -n --hidden --glob='*.adoc' -S \
"compatible with|compatibility|supported.*(OpenShift|OVirt|Virtualization)|supported.*version|version.*supported|support.*matrix|matrix" \
documentation . \
| head -200
# Search specifically for OpenShift Virtualization + supported OpenShift/container platform version statements.
rg -n --hidden --glob='*.adoc' -S \
"OpenShift Virtualization|OVirt|{virt}|OpenShift Virtualization 4\." \
documentation . \
| head -200
# Look for existing cross-references around the same section/file.
rg -n --hidden --glob='*.adoc' -S \
"ref_cnv-prerequisites|cnv-prerequisites|xref:.*ref_cnv-prerequisites|link:.*ref_cnv-prerequisites" \
documentation . \
|| true
# Check whether this file already references an IMPORTANT box about compatibility.
sed -n '1,120p' documentation/modules/ref_cnv-prerequisites.adocRepository: kubev2v/forklift-documentation
Length of output: 50578
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# 1) Find the exact compatibility-matrix-like sentence
rg -n --hidden --glob='*.adoc' -S \
-F 'version of {virt} that is compatible with your version of {project-short}' \
documentation \
|| true
rg -n --hidden --glob='*.adoc' -S \
-F 'compatible versions of {virt} are' \
documentation \
|| true
# 2) Find any mention of "compatible with your {project-short}" phrasing
rg -n --hidden --glob='*.adoc' -S \
'compatible with your \{project-short\} version' documentation || true
# 3) Show the surrounding section for the known match file
FILE="documentation/modules/ref_target-vm-scheduling-prerequisites.adoc"
if [ -f "$FILE" ]; then
echo "---- $FILE (relevant excerpt) ----"
# show around the match lines if rg found it, otherwise first 120 lines
MATCH_LINE="$(rg -n --hidden --glob='*.adoc' -S -F 'version of {virt} that is compatible with your version of {project-short}' "$FILE" | cut -d: -f1 | head -1 || true)"
if [ -n "${MATCH_LINE}" ]; then
START=$((MATCH_LINE-20))
END=$((MATCH_LINE+60))
sed -n "${START},${END}p" "$FILE" | cat -n
else
sed -n '1,160p' "$FILE" | cat -n
fi
fiRepository: kubev2v/forklift-documentation
Length of output: 3264
Add an xref for {virt} ↔ {project-short} compatibility guidance
Line 10 implies readers can check a compatibility matrix for “your {project-short} version,” which is documented in documentation/modules/ref_target-vm-scheduling-prerequisites.adoc (and the same text appears in documentation/modules/proc_configuring-target-vm-scheduling-cli.adoc). Add a link/xref from ref_cnv-prerequisites.adoc to that section so users know where to find the compatible {virt} versions per {project-short} release.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@documentation/modules/ref_cnv-prerequisites.adoc` at line 10, Add an xref
from the sentence mentioning {virt} and {project-short} in
ref_cnv-prerequisites.adoc to the compatibility guidance in
documentation/modules/ref_target-vm-scheduling-prerequisites.adoc (same text
also in proc_configuring-target-vm-scheduling-cli.adoc); update the sentence
that references “your {project-short} version” to include an Asciidoc xref to
the target-vm-scheduling prerequisites page so readers can click through to the
compatibility matrix for {virt} ↔ {project-short} versions.
nogunix
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CNV prerequisites incorrectly required matching MTV versions on both
clusters. The matching-version requirement applies to OpenShift Virtualization,
not MTV - MTV only needs to be installed on one cluster, which orchestrates the
other via a remote provider.
Fixes https://issues.redhat.com/browse/MTV-5727
Summary by CodeRabbit