Chore: Upgrade Go version and update kin openapi dependencies#14
Closed
vishal210893 wants to merge 1 commit intokubevela:mainfrom
Closed
Chore: Upgrade Go version and update kin openapi dependencies#14vishal210893 wants to merge 1 commit intokubevela:mainfrom
vishal210893 wants to merge 1 commit intokubevela:mainfrom
Conversation
vishal210893
requested review from
FogDong,
anoop2811,
barnettZQG and
wonderflow
as code owners
Signed-off-by: viskumar <viskumar@guidewire.com>
vishal210893
force-pushed
the
feature/upgrade-version
branch
from
b3c8d97 to
2ef31ba
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic found 2 issues across 2 files. Review them in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
| go 1.19 | ||
| go 1.22.5 | ||
|
|
||
| toolchain go1.24.2 |
There was a problem hiding this comment.
The toolchain directive should reference a Go toolchain in major.minor form; including a patch suffix makes the directive invalid and prevents module commands from running.
Suggested change
| toolchain go1.24.2 | |
| toolchain go1.24 |
| module github.com/oam-dev/kubevela-core-api | ||
|
|
||
| go 1.19 | ||
| go 1.22.5 |
There was a problem hiding this comment.
The go directive must specify only the language version (major.minor). Including the patch number results in an invalid go.mod file and will break go commands.
Suggested change
| go 1.22.5 | |
| go 1.22 |
FogDong
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Upgraded the Go version to 1.22.5 and updated kin-openapi and related dependencies for better compatibility and support.
Parameter.JSONTypefield to use*openapi3.Types.