Add/workflowstep definition fixes

[roguepikachu]

Description of your changes

copilot:all

Workflow Step Definition Fixes:

1. vela-cli

• Replaced raw builtin.#Fail CUE reference with defkit.Fail() fluent builder
• Replaced manual builtin.#ConditionalWait builder calls with defkit.WaitUntil().Guard() fluent builder for job status wait
• mountsArray and volumesList use fluent ForEachGuarded builders (requires framework fix for inner braces)
• deDupVolumesArray uses defkit.From(defkit.Reference("volumesList")).Dedupe("name") (requires framework fix for Ref source support)
• Removed unused hasJobSucceededStatus variable

2. step-group

• Added TemplateBody("// no parameters, the nop only to make the template not empty or it's invalid\nnop: {}") to replace empty parameter: {} with a valid nop placeholder
• Leverages framework change that skips parameter block when TemplateBody is set with no params

3. share-cloud-resource

• Used WithDirectFields() to render op.#ShareCloudResource fields (env, placements, policy) directly without $params wrapper
• Restored defkit.VelaCtx() fluent builder usage

4. webhook

• Rewrote using fluent builders: KubeRead, HTTPPost, ConvertString for cleaner templates
• Made url parameter a closed union (value or secretRef)
• Correctly reads Application/Secret and POSTs JSON

5. suspend

• Added trailing newline for proper formatting

6. Test coverage

• New vela_cli_test.go: 59 specs covering metadata, imports, parameters (command, image, serviceAccountName, storage), template blocks (mountsArray, volumesList, deDupVolumesArray, job, log, fail, wait)
• New step_group_test.go: 7 specs covering nop placeholder and parameter suppression
• New share_cloud_resource_test.go: 17 specs covering direct field rendering
• New webhook_test.go: comprehensive specs covering metadata, CUE generation, and closed union parameters

Dependency:

Requires kubevela/kubevela#7069 for framework changes (ForEachGuarded inner braces, Dedupe for Ref sources, WithDirectFields, TemplateBody parameter suppression).

How has this code been tested

• All workflow step unit tests pass (go test -v -race -count=1 ./workflowsteps/...)
• Tests use Ginkgo/Gomega and validate generated CUE output against expected patterns

Special notes for your reviewer

All definition changes maximize fluent builder usage over raw CUE strings. Each fix was driven by comparing defkit-generated CUE against the original hand-written CUE definitions in translations/.

[roguepikachu]

DO NOT MERGE - Dependency on KubeVela PR kubevela/kubevela#7069

[cubic-dev-ai]

3 issues found across 59 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="workflowsteps/workflowsteps_test.go">

<violation number="1" location="workflowsteps/workflowsteps_test.go:45">
P2: The "All WorkflowSteps Registered" test relies on a manual step list and is already missing registered workflow steps, so it does not truly verify registration completeness.</violation>
</file>

<file name="workflowsteps/clean_jobs_test.go">

<violation number="1" location="workflowsteps/clean_jobs_test.go:116">
P2: Test asserts lowercase `kind: "pod"`, which conflicts with Kubernetes Kind conventions (CamelCase) and may lock in an invalid Kind for pod deletion.</violation>
</file>

<file name="workflowsteps/collect_service_endpoints_test.go">

<violation number="1" location="workflowsteps/collect_service_endpoints_test.go:222">
P2: App-block parsing in test is brace-naive and exits at inner `}`, allowing forbidden guards later in `app` to go unchecked.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

7 issues found across 31 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="workflowsteps/build_push_image_test.go">

<violation number="1" location="workflowsteps/build_push_image_test.go:60">
P2: Credential schema assertions were removed, reducing test coverage for required secret fields (`name`/`key`) in `#secret` and nested credential blocks.</violation>

<violation number="2" location="workflowsteps/build_push_image_test.go:115">
P2: Consolidated lifecycle test no longer verifies that `read: kube.#Read` targets `kind: "Pod"`, allowing read-kind regressions to pass.</violation>
</file>

<file name="workflowsteps/apply_terraform_provider_test.go">

<violation number="1" location="workflowsteps/apply_terraform_provider_test.go:112">
P2: Refactor removed explicit assertions for several required provider env-key mappings, weakening regression coverage for ApplyTerraformProvider config generation.</violation>
</file>

<file name="workflowsteps/restart_workflow_test.go">

<violation number="1" location="workflowsteps/restart_workflow_test.go:64">
P2: Test assertions were weakened: they no longer explicitly verify `if parameter.<x> != _|_` branch guards for `_script`, so branch-generation regressions may go undetected.</violation>
</file>

<file name="workflowsteps/request_test.go">

<violation number="1" location="workflowsteps/request_test.go:63">
P2: Test consolidation removed assertion of the `op.#Fail` message content, weakening regression coverage for user-visible request failure diagnostics.</violation>
</file>

<file name="workflowsteps/vela_cli_test.go">

<violation number="1" location="workflowsteps/vela_cli_test.go:127">
P2: Refactored test weakens log selector validation by checking only `labelSelector:` presence and no longer asserting the required `workflow.oam.dev/step-name` key.</violation>

<violation number="2" location="workflowsteps/vela_cli_test.go:134">
P2: Refactored test removed wait-specific guard assertions, weakening coverage for safe `status.succeeded` dereference.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}