Skip to content

Fix: fix compatibility for output #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Feb 26, 2025

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@FogDong FogDong changed the title fix: fix compatibility for output Fix: fix compatibility for output Feb 26, 2025
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.51%. Comparing base (c3331e7) to head (9a6b6c1).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
pkg/hooks/data_passing.go 66.66% 1 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (66.66%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
- Coverage   63.44%   62.51%   -0.94%     
==========================================
  Files          51       62      +11     
  Lines        4604     4412     -192     
==========================================
- Hits         2921     2758     -163     
- Misses       1282     1322      +40     
+ Partials      401      332      -69     
Flag Coverage Δ
unit-test 62.51% <66.66%> (-0.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FogDong FogDong merged commit 23468c9 into kubevela:main Feb 26, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant