CNV-77466: Refactor generation script and re-generate kubevirt API#82
Draft
rszwajko wants to merge 4 commits intokubevirt-ui:mainfrom
Draft
CNV-77466: Refactor generation script and re-generate kubevirt API#82rszwajko wants to merge 4 commits intokubevirt-ui:mainfrom
rszwajko wants to merge 4 commits intokubevirt-ui:mainfrom
Conversation
Create an object of type V1ACPI and provide all properties. Do not test conversion functions V1ACPIFromJSON and V1ACPIToJSON. Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Use V1ACPI test as an example. Generated with claude-4.5-opus-high. Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Use the tests for V1AcceessCredential and V1ACPI as examples. Generated with claude-4.5-opus-high. Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi, welcome to kubevirt ui, thank you this pull request 💖✨ |
1. Split generation script - one script per folder. 2. re-generated kubevirt API using the new script 3. create a script for removing ununsed conversion methods 4. remove unused fetch API code 5. lint the code 6. verify with tests that the code was generated correctly TODO: handle VirtualMachinePool related types manually. Generated with claude-4.5-opus-high. Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
rszwajko
force-pushed
the
aiChallangeRegenerate
branch
from
62ba1ff to
9ad4532
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #81
TODO: handle VirtualMachinePool related types manually.
Generated with claude-4.5-opus-high.