-
Notifications
You must be signed in to change notification settings - Fork 38
WIP: CNV-58540: Update Segment endpoints #2531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@pcbailey: This pull request references CNV-58540 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pcbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -60,17 +67,16 @@ const initSegment = () => { | |||
const t = document.createElement('script'); | |||
t.type = 'text/javascript'; | |||
t.async = true; | |||
t.src = | |||
'https://cdn.segment.com/analytics.js/v1/' + encodeURIComponent(key) + '/analytics.min.js'; | |||
t.src = jsURL; | |||
const n = document.getElementsByTagName('script')[0]; | |||
if (n.parentNode) { | |||
n.parentNode.insertBefore(t, n); | |||
} | |||
analytics._loadOptions = e; | |||
}; | |||
analytics.SNIPPET_VERSION = '4.13.1'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what abou version?
@pcbailey where do we stand with it? |
📝 Description
This PR updates the Segment endpoint to use
console.redhat.com
.Jira: https://issues.redhat.com/browse/CNV-58540