Skip to content

CNV-60049: fix interface modal with udn #2583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

CNV-60049: fix interface modal with udn #2583

merged 1 commit into from
Apr 22, 2025

Conversation

upalatucci
Copy link
Member

📝 Description

Filter out NADs created from udn resources

🎥 Demo

Before

Screenshot 2025-04-16 at 10 04 26

After

Screenshot 2025-04-16 at 10 01 45

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 16, 2025 •
edited by openshift-ci bot
Loading

@upalatucci: This pull request references CNV-60049 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

📝 Description

Filter out NADs created from udn resources

🎥 Demo

Before

Screenshot 2025-04-16 at 10 04 26

After

Screenshot 2025-04-16 at 10 01 45

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from adamviktora and pcbailey April 16, 2025 08:04
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Apr 16, 2025
@rszwajko rszwajko self-requested a review April 16, 2025 08:16
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Apr 16, 2025
@upalatucci
Copy link
Member Author

/retest

@upalatucci
Copy link
Member Author

/retest

@upalatucci upalatucci force-pushed the fix-udn-interfacemodal branch from cf6267b to ae57598 Compare April 17, 2025 08:17
@openshift-ci openshift-ci bot removed the lgtm Passed code review, ready for merge label Apr 17, 2025
@upalatucci upalatucci force-pushed the fix-udn-interfacemodal branch from ae57598 to 25afedb Compare April 17, 2025 08:18
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Apr 17, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adamviktora, rszwajko, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adamviktora,rszwajko,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@upalatucci
Copy link
Member Author

/retest

1 similar comment
@upalatucci
Copy link
Member Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 7511530 into kubevirt-ui:main Apr 22, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rszwajko rszwajko rszwajko approved these changes

@adamviktora adamviktora adamviktora approved these changes

@pcbailey pcbailey Awaiting requested review from pcbailey

Assignees

@rszwajko rszwajko

@adamviktora adamviktora

Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@upalatucci @openshift-ci-robot @rszwajko @adamviktora