Skip to content

CNV-56688: Avoid CPU helper text error if CPU threads is undefined #2614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pcbailey
Copy link
Member

📝 Description

Jira: https://issues.redhat.com/browse/CNV-56688

🎥 Screenshots

Before

cpu-helper-text--BEFORE--2025-04-30_10-57

After

cpu-helper-text--AFTER--2025-04-30_11-01

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 30, 2025

@pcbailey: This pull request references CNV-56688 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

📝 Description

Jira: https://issues.redhat.com/browse/CNV-56688

🎥 Screenshots

Before

cpu-helper-text--BEFORE--2025-04-30_10-57

After

cpu-helper-text--AFTER--2025-04-30_11-01

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from gouyang and lkladnit April 30, 2025 15:08
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Apr 30, 2025
@pcbailey
Copy link
Member Author

pcbailey commented May 1, 2025

/retest

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label May 2, 2025
@upalatucci
Copy link
Member

/retest

@lkladnit
Copy link
Collaborator

lkladnit commented May 3, 2025

/lgtm

Copy link
Contributor

openshift-ci bot commented May 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkladnit, pcbailey, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkladnit,pcbailey,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lkladnit
Copy link
Collaborator

lkladnit commented May 3, 2025

/retest-required

Copy link
Contributor

openshift-ci bot commented May 3, 2025

@pcbailey: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/kubevirt-e2e-aws 13ad342 link true /test kubevirt-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants