CNV-70175: Fix error to restart vm when changing vcpu in 4.18 #3315
Conversation
|
@batyana: This pull request references CNV-70175 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.z" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@batyana: This pull request references CNV-70175 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.z" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@batyana: This pull request references CNV-70175 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.z" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
...MemoryModal/components/CPUInput/components/CPUTopologyInput/components/CPUComponentInput.tsx
Outdated
Show resolved
Hide resolved
src/views/templates/details/tabs/details/components/CPUMemoryModal/CPUMemoryModal.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| vmDraft.spec.template.spec.domain.cpu = cpu; | ||
| vmDraft.spec.template.spec.domain.memory.guest = `${memory}${memoryUnit}`; | ||
| vmDraft.spec.template.spec.domain.memory.guest = `${memory}${memoryUnit || ''}`; |
There was a problem hiding this comment.
do we really need the || part?
and it's better to use ?? instead
There was a problem hiding this comment.
we need this since memoryUnit could be undefined, changed to ?? instead of ||
src/utils/components/CPUMemoryModal/components/CPUInput/utils/utils.ts
Outdated
Show resolved
Hide resolved
src/utils/components/CPUMemoryModal/components/CPUInput/utils/utils.ts
Outdated
Show resolved
Hide resolved
src/utils/components/CPUMemoryModal/components/CPUInput/utils/utils.ts
Outdated
Show resolved
Hide resolved
src/utils/components/CPUMemoryModal/components/CPUInput/utils/utils.ts
Outdated
Show resolved
Hide resolved
|
@batyana: This pull request references CNV-70175 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.z" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Signed-off-by: batyana <[email protected]>
batyana
force-pushed
the
CNV-70175-fix-rerun-error-when-updating-vcpu-4.18
branch
from
ec026f5 to
8292211
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, batyana The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 528cf78
into
kubevirt-ui:release-4.18
3 participants
📝 Description
backporting #3312 to 4.18
Screen.Recording.2025-12-24.at.14.50.49.mov