CNV-74670: installed features in High availability are checked #3320

adamviktora · 2026-01-05T13:11:08Z

📝 Description

Installed features in Settings -> Configure features modal -> High availability are now checked.

(We can't make the checkboxes enabled, because the modal can't uninstall the features.)

🎥 Demo

After:

Summary by CodeRabbit

Bug Fixes
- Fixed high availability feature configuration display to correctly show the checked state when virtualization operators are already installed on the cluster, regardless of their current selection status. This ensures accurate visual feedback during cluster configuration.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

openshift-ci-robot · 2026-01-05T13:11:12Z

@adamviktora: This pull request references CNV-74670 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

📝 Description

Installed features in Settings -> Configure features modal -> High availability are now checked.

(We can't make the checkboxes enabled, because the modal can't uninstall the features.)

🎥 Demo

After:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-01-05T13:11:20Z

📝 Walkthrough

Walkthrough

A single checkbox state logic modification in the HighAvailabilityFeatureItem component. The isChecked property now evaluates to operatorsToInstall?.[operatorName] || installed instead of only checking operatorsToInstall?.[operatorName], ensuring the checkbox reflects both newly selected operators and already-installed ones.

Changes

Cohort / File(s)	Summary
High Availability UI State Logic `src/views/clusteroverview/SettingsTab/ClusterTab/components/.../HighAvailabilityFeatureItem/HighAvailabilityFeatureItem.tsx`	Modified checkbox `isChecked` condition to include OR logic with `installed` flag, allowing the checkbox to display as checked when operators are either selected for installation or already installed

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

CNV-74667: Fix wrong display of high availability status #3288: Modifies High Availability UI logic for determining operator installation and display states in similar checkbox/feature contexts.

Suggested labels

lgtm, approved

Suggested reviewers

batyana
gouyang
upalatucci

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: installed features in High availability are now checked in the UI.
Description check	✅ Passed	The description covers the main change and includes a demo screenshot, but lacks details about implementation specifics and testing.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2026-01-05T13:12:57Z

@adamviktora: This pull request references CNV-74670 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

📝 Description

Installed features in Settings -> Configure features modal -> High availability are now checked.

(We can't make the checkboxes enabled, because the modal can't uninstall the features.)

🎥 Demo

After:

Summary by CodeRabbit

Bug Fixes

Fixed high availability feature configuration display to correctly show the checked state when virtualization operators are already installed on the cluster, regardless of their current selection status. This ensures accurate visual feedback during cluster configuration.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/views/clusteroverview/SettingsTab/ClusterTab/components/VirtualizationFeaturesSection/VirtualizationFeaturesWizard/components/ConfigurationStep/components/HighAvailabilityConfigurationSection/components/HighAvailabilityContent/HighAvailabilityFeatureItem/HighAvailabilityFeatureItem.tsx (1)
33-34: Add defensive handling for potentially undefined operatorDetailsMap entry.

The optional chaining on line 33 may result in undefined values for both installState and operatorHubURL if operatorDetailsMap is undefined or the operator key doesn't exist. While isInstalled returns false when passed undefined (preventing runtime errors), this is a type safety issue—the function signature expects InstallState, not InstallState | undefined.

Consider adding explicit defaults:
Suggested approach
-  const { installState, operatorHubURL } = operatorDetailsMap?.[operatorName];
+  const { installState = InstallState.UNKNOWN, operatorHubURL = '' } = operatorDetailsMap?.[operatorName] ?? {};
   const installed = isInstalled(installState);
This ensures isInstalled receives a valid InstallState enum value rather than undefined, making the type handling explicit and correct.

🧹 Nitpick comments (1)

src/views/clusteroverview/SettingsTab/ClusterTab/components/VirtualizationFeaturesSection/VirtualizationFeaturesWizard/components/ConfigurationStep/components/HighAvailabilityConfigurationSection/components/HighAvailabilityContent/HighAvailabilityFeatureItem/HighAvailabilityFeatureItem.tsx (1)
23-75: Consider wrapping the component in React.memo for performance.

While the component is relatively simple, the coding guidelines recommend using React memoization tools to avoid unnecessary re-renders. Wrapping this component in React.memo could prevent re-renders when parent components update but props remain the same.
🔎 Example implementation
-const HighAvailabilityFeatureItem: FC<HighAvailabilityFeatureItemProps> = ({
+const HighAvailabilityFeatureItem: FC<HighAvailabilityFeatureItemProps> = React.memo(({
   alternativeChecked,
   checkboxLabel,
   description,
   operatorName,
   setAlternativeChecked,
-}) => {
+}) => {
   const { operatorDetailsMap, operatorsToInstall, updateInstallRequests } =
     useVirtualizationFeaturesContext();
   
   // ... rest of component
   
   return (
     // ... JSX
   );
-};
+});
+
+HighAvailabilityFeatureItem.displayName = 'HighAvailabilityFeatureItem';
 
 export default HighAvailabilityFeatureItem;
As per coding guidelines, memoization helps optimize render performance.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3681b7e and 12908d8.

📒 Files selected for processing (1)

src/views/clusteroverview/SettingsTab/ClusterTab/components/VirtualizationFeaturesSection/VirtualizationFeaturesWizard/components/ConfigurationStep/components/HighAvailabilityConfigurationSection/components/HighAvailabilityContent/HighAvailabilityFeatureItem/HighAvailabilityFeatureItem.tsx

🧰 Additional context used

📓 Path-based instructions (6)

**/*.tsx