Skip to content

Conversation

@galkremer1
Copy link
Member

@galkremer1 galkremer1 commented Feb 10, 2026

📝 Description

Jira ticket:CNV-78915

Removing the network checkup as it is being deprecated.

🎥 Demo

Demo.mov

Summary by CodeRabbit

  • Removed Features

    • Network latency checkup has been removed — users can no longer create, run, view details, or manage network latency checkups; storage and self‑validation checkups remain.
  • Localization

    • Latency and network-latency related UI strings removed from several locales.
  • Navigation

    • Checkups navigation and tabs updated to focus on storage and self‑validation.
  • Tests

    • End-to-end network checkup test cases removed.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 10, 2026

@galkremer1: This pull request references CNV-78915 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

📝 Description

Jira ticket:CNV-78915

Removing the network checkup as it is being deprecated.

🎥 Demo

Demo.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Feb 10, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 10, 2026

📝 Walkthrough

Walkthrough

This PR removes the network latency checkups feature: UI components, hooks, utilities, routes, documentation URL, and locale strings for network/latency across multiple locales.

Changes

Cohort / File(s) Summary
Locale Translations
locales/en/plugin__kubevirt-plugin.json, locales/es/plugin__kubevirt-plugin.json, locales/fr/plugin__kubevirt-plugin.json, locales/ja/plugin__kubevirt-plugin.json, locales/ko/plugin__kubevirt-plugin.json, locales/zh/plugin__kubevirt-plugin.json
Removed locale keys related to network latency, latency checkups, NetworkAttachmentDefinition, and time-unit displays.
Routes & Extensions
src/multicluster/extensions.ts, src/views/checkups/extensions.ts
Removed network checkup route/extension entries and updated Checkups navigation href (network → storage).
Checkups Run / Empty State
src/views/checkups/CheckupsRunButton.tsx, src/views/checkups/components/CheckupsEmptyState/CheckupsEmptyState.tsx, src/views/checkups/components/CheckupsEmptyState/utils.ts
Removed NETWORK branches and network-specific permissions/URLs; changed documentation URL signature to parameterless.
Checkups Constants & URLs
src/views/checkups/utils/constants.ts, src/views/checkups/utils/getCheckUpsTabs.tsx, src/views/checkups/utils/utils.ts, src/utils/constants/documentation.ts, src/utils/resources/checkups/urls.ts
Removed NETWORK from CHECKUP_URLS and tab list; removed CHECKUPS_LATENCY doc key and getNetworkCheckupURL helper; getCurrentCheckupType no longer detects network.
Network Form & Styling
src/views/checkups/network/components/form/CheckupsNetworkForm.tsx, src/views/checkups/network/components/form/CheckupsNetworkFormActions.tsx, src/views/checkups/network/components/form/CheckupsNetworkFormLatency.tsx, src/views/checkups/network/components/form/CheckupsNetworkFormNADS.tsx, src/views/checkups/network/components/form/CheckupsNetworkFormNodes.tsx, src/views/checkups/network/components/form/checkups-network-form.scss
Deleted the entire network checkup form, actions, subcomponents, and associated SCSS.
Network Details & Tabs
src/views/checkups/network/details/CheckupsNetworkDetailsPage.tsx, src/views/checkups/network/details/CheckupsNetworkDetailsPageHeader.tsx, src/views/checkups/network/details/tabs/details/CheckupsNetworkDetailsPageSection.tsx, src/views/checkups/network/details/tabs/details/CheckupsNetworkDetailsTab.tsx, src/views/checkups/network/details/tabs/yaml/CheckupsNetworkYAMLTab.tsx, src/views/checkups/network/details/checkups-network-details-page.scss
Removed network checkup details page, header, tabs (Details/YAML), section component, and related styles.
Network List & Rows
src/views/checkups/network/list/CheckupsNetworkList.tsx, src/views/checkups/network/list/CheckupsNetworkListEmptyState.tsx, src/views/checkups/network/list/CheckupsNetworkListRow.tsx
Deleted the network checkup list page, empty-state component, and table row component.
Network Hooks
src/views/checkups/network/hooks/useCheckupsNetworkData.ts, src/views/checkups/network/hooks/useCheckupsNetworkFilters.ts, src/views/checkups/network/hooks/useCheckupsNetworkListColumns.ts, src/views/checkups/network/hooks/useCheckupsNetworkPermissions.ts, src/views/checkups/network/details/hooks/useCheckupsNetworkTabs.ts
Removed data fetching, filtering, columns, permissions, and tab hook implementations for network checkups.
Network Actions, Utils & Consts
src/views/checkups/network/components/CheckupsNetworkActions.tsx, src/views/checkups/network/utils/const.ts, src/views/checkups/network/utils/filters.ts, src/views/checkups/network/utils/utils.ts
Deleted network actions component, image constants, status filters, and utilities that handled RBAC, ConfigMap/Job creation, deletion, rerun, and related constants.
Tests
cypress/tests/gating/check-tab-yaml.cy.ts
Removed network tab test block; adjusted storage test to visit checkups prior to storage tab interaction.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

Suggested labels

lgtm

Suggested reviewers

  • aviavissar
  • rszwajko
  • upalatucci
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: removing the VM latency checkup from the UI.
Description check ✅ Passed The description includes a Jira ticket reference and explanation of the change, but lacks detail on scope and testing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 10, 2026

@galkremer1: This pull request references CNV-78915 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

📝 Description

Jira ticket:CNV-78915

Removing the network checkup as it is being deprecated.

🎥 Demo

Demo.mov

Summary by CodeRabbit

Release Notes

  • Removed Features
  • Network latency checkup feature has been removed. Users can no longer create, run, or manage network latency checkups. Only storage and self-validation checkups remain available.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@galkremer1
Copy link
Member Author

/retest

@adamviktora
Copy link
Member

This cypress test needs to be removed too: network checkup pages is loaded

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Feb 11, 2026
@upalatucci
Copy link
Member

/remove-lgtm

@openshift-ci openshift-ci bot removed the lgtm Passed code review, ready for merge label Feb 11, 2026
@galkremer1 galkremer1 force-pushed the CNV-78915-remove-latency-checkup branch from 1600272 to 9fe8421 Compare February 11, 2026 15:40
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 11, 2026

@galkremer1: This pull request references CNV-78915 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

📝 Description

Jira ticket:CNV-78915

Removing the network checkup as it is being deprecated.

🎥 Demo

Demo.mov

Summary by CodeRabbit

  • Removed Features

  • Network latency checkup has been removed — users can no longer create, run, view details, or manage network latency checkups; storage and self‑validation checkups remain.

  • Localization

  • Latency and network-latency related UI strings removed from several locales.

  • Navigation

  • Checkups navigation and tabs updated to focus on storage and self‑validation.

  • Tests

  • End-to-end network checkup test cases removed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Feb 11, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 11, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: galkremer1, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [galkremer1,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 11, 2026

@galkremer1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/kubevirt-e2e-aws 9fe8421 link true /test kubevirt-e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants