CNV-79541: Fix incorrect minimum disk size validation for CD-ROM

[upalatucci]

📝 Description

The template catalog drawer was incorrectly enforcing the root disk minimum size (e.g. 60 GiB) on the CD-ROM source input. The SelectSource component always computed minDiskValue from the root disk via getRootDiskStorageRequests, regardless of whether it was being used for the CD-ROM or the main disk.

This fix only enforces the root disk minimum when withSize is true, which is only passed for the actual disk source. For the CD-ROM source (withSize defaults to false), minDiskValue is now undefined, correctly skipping the minimum size validation.

Jira: https://issues.redhat.com/browse/CNV-79541

🎥 Demo

BEFORE

AFTER

No error message

Summary by CodeRabbit

• Bug Fixes
  • Improved disk storage validation to correctly handle cases where size information is unavailable.

[openshift-ci-robot]

@upalatucci: This pull request references CNV-79541 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

📝 Description

The template catalog drawer was incorrectly enforcing the root disk minimum size (e.g. 60 GiB) on the CD-ROM source input. The SelectSource component always computed minDiskValue from the root disk via getRootDiskStorageRequests, regardless of whether it was being used for the CD-ROM or the main disk.

This fix only enforces the root disk minimum when withSize is true, which is only passed for the actual disk source. For the CD-ROM source (withSize defaults to false), minDiskValue is now undefined, correctly skipping the minimum size validation.

Jira: https://issues.redhat.com/browse/CNV-79541

🎥 Demo

TODO: add screenshot/video

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

📝 Walkthrough

Walkthrough

Modified conditional logic in the SelectSource component to calculate minDiskValue only when withSize is true. This affects downstream validation logic affecting the isMinusDisabled state.

Changes

Cohort / File(s)	Summary
Storage Value Calculation src/views/catalog/templatescatalog/components/TemplatesCatalogDrawer/StorageSection/CustomizeSource/SelectSource.tsx	Modified minDiskValue computation to be conditional on withSize flag; when false, minDiskValue becomes undefined, affecting downstream validation logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested labels

lgtm, approved

Suggested reviewers

• lkladnit
• galkremer1
• metalice

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and specifically describes the main fix: correcting minimum disk size validation incorrectly applied to CD-ROM sources.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check	✅ Passed	The PR description comprehensively covers the bug, root cause, fix, and includes demo screenshots showing before/after behavior.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@upalatucci: This pull request references CNV-79541 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

📝 Description

The template catalog drawer was incorrectly enforcing the root disk minimum size (e.g. 60 GiB) on the CD-ROM source input. The SelectSource component always computed minDiskValue from the root disk via getRootDiskStorageRequests, regardless of whether it was being used for the CD-ROM or the main disk.

This fix only enforces the root disk minimum when withSize is true, which is only passed for the actual disk source. For the CD-ROM source (withSize defaults to false), minDiskValue is now undefined, correctly skipping the minimum size validation.

Jira: https://issues.redhat.com/browse/CNV-79541

🎥 Demo

BEFORE

AFTER

No error message

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@upalatucci: This pull request references CNV-79541 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

📝 Description

The template catalog drawer was incorrectly enforcing the root disk minimum size (e.g. 60 GiB) on the CD-ROM source input. The SelectSource component always computed minDiskValue from the root disk via getRootDiskStorageRequests, regardless of whether it was being used for the CD-ROM or the main disk.

This fix only enforces the root disk minimum when withSize is true, which is only passed for the actual disk source. For the CD-ROM source (withSize defaults to false), minDiskValue is now undefined, correctly skipping the minimum size validation.

Jira: https://issues.redhat.com/browse/CNV-79541

🎥 Demo

BEFORE

AFTER

No error message

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@upalatucci: This pull request references CNV-79541 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

📝 Description

The template catalog drawer was incorrectly enforcing the root disk minimum size (e.g. 60 GiB) on the CD-ROM source input. The SelectSource component always computed minDiskValue from the root disk via getRootDiskStorageRequests, regardless of whether it was being used for the CD-ROM or the main disk.

This fix only enforces the root disk minimum when withSize is true, which is only passed for the actual disk source. For the CD-ROM source (withSize defaults to false), minDiskValue is now undefined, correctly skipping the minimum size validation.

Jira: https://issues.redhat.com/browse/CNV-79541

🎥 Demo

BEFORE

AFTER

No error message

Summary by CodeRabbit

• Bug Fixes
• Improved disk storage validation to correctly handle cases where size information is unavailable.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[upalatucci]

/hold