Skip to content

CNV-72480: migrate instancetypes and preferences to KubevirtTable#3613

Draft
batyana wants to merge 2 commits intokubevirt-ui:mainfrom
batyana:CNV-74280-pr11-instancetypes-preferences
Draft

CNV-72480: migrate instancetypes and preferences to KubevirtTable#3613
batyana wants to merge 2 commits intokubevirt-ui:mainfrom
batyana:CNV-74280-pr11-instancetypes-preferences

Conversation

@batyana
Copy link
Member

@batyana batyana commented Mar 15, 2026

📝 Description

Summary

  • Migrate Instance Types and Preferences list tables from deprecated VirtualizedTable to KubevirtTable
  • Apply established migration patterns from previous PRs (pagination, column definitions, multicluster support)
  • Clean up obsolete files (row components, column hooks)

Changes

Table Status
UserInstancetypeList ✅ Migrated
ClusterInstancetypeList ✅ Migrated
UserPreferenceList ✅ Migrated
ClusterPreferenceList ✅ Migrated

Key improvements:

  • Proper multicluster support with MulticlusterResourceLink
  • Client-side pagination with usePaginationWithFilters
  • Memory display shows "—" instead of "0 B" when value is missing
  • Row IDs include cluster for multicluster uniqueness
  • Shared buildColumnLayout utility reduces code duplication

🎥 Demo

Please add a video or an image of the behavior/changes

batyana added 2 commits March 15, 2026 01:52
Signed-off-by: batyana <bnahmias@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 15, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 15, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: batyana
Once this PR has been reviewed and has the lgtm label, please assign galkremer1 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link

coderabbitai bot commented Mar 15, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a0b6d2d9-d07c-42a3-a083-ccb3f462347e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@batyana batyana changed the title Cnv 74280 pr11 instancetypes preferences CNV-72480: migrate instancetypes and preferences to KubevirtTable Mar 15, 2026
@openshift-ci-robot
Copy link
Collaborator

@batyana: An error was encountered searching for bug CNV-72480 on the Jira server at https://issues.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. No response returned: Get "https://issues.redhat.com/rest/api/2/issue/CNV-72480": GET https://issues.redhat.com/rest/api/2/issue/CNV-72480 giving up after 5 attempt(s)

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

📝 Description

Summary

  • Migrate Instance Types and Preferences list tables from deprecated VirtualizedTable to KubevirtTable
  • Apply established migration patterns from previous PRs (pagination, column definitions, multicluster support)
  • Clean up obsolete files (row components, column hooks)

Changes

Table Status
UserInstancetypeList ✅ Migrated
ClusterInstancetypeList ✅ Migrated
UserPreferenceList ✅ Migrated
ClusterPreferenceList ✅ Migrated

Key improvements:

  • Proper multicluster support with MulticlusterResourceLink
  • Client-side pagination with usePaginationWithFilters
  • Memory display shows "—" instead of "0 B" when value is missing
  • Row IDs include cluster for multicluster uniqueness
  • Shared buildColumnLayout utility reduces code duplication

🎥 Demo

Please add a video or an image of the behavior/changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants