CNV-81184: Change modal wording according to new design#3614
CNV-81184: Change modal wording according to new design#3614batyana wants to merge 1 commit intokubevirt-ui:mainfrom
Conversation
|
@batyana: An error was encountered searching for bug CNV-81184 on the Jira server at https://issues.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
No response returned: Get "https://issues.redhat.com/rest/api/2/issue/CNV-81184": GET https://issues.redhat.com/rest/api/2/issue/CNV-81184 giving up after 5 attempt(s)
Please contact an administrator to resolve this issue, then request a bug refresh with DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
📝 WalkthroughWalkthroughRemoved three legacy CD-ROM localization keys, added several ISO/upload and drive-setup localization keys across locales; refactored AddCDROMModal layout to use Stack with updated prompt and restart alert; and localized upload alert strings in storage constants. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip You can enable review details to help with troubleshooting, context usage and more.Enable the |
|
@batyana: An error was encountered searching for bug CNV-81184 on the Jira server at https://issues.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
No response returned: Get "https://issues.redhat.com/rest/api/2/issue/CNV-81184": GET https://issues.redhat.com/rest/api/2/issue/CNV-81184 giving up after 5 attempt(s)
Please contact an administrator to resolve this issue, then request a bug refresh with DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@locales/es/plugin__kubevirt-plugin.json`:
- Line 1685: Two translation entries remain in English; replace the English
string values for the keys matching "Select how you would like to set up the new
drive" and "To finish adding the CD-ROM drive, stop and restart the virtual
machine." with Spanish translations. Locate these exact string keys in
plugin__kubevirt-plugin.json (the entries currently set to the English phrases)
and update their values to: "Seleccione cómo desea configurar la nueva unidad"
for the first and "Para terminar de agregar la unidad de CD-ROM, detenga y
reinicie la máquina virtual." for the second, keeping JSON quoting/escaping
consistent.
In `@locales/fr/plugin__kubevirt-plugin.json`:
- Line 1685: Replace the English value for the JSON key "Select how you would
like to set up the new drive" in the French locale with a proper French
translation in locales/fr/plugin__kubevirt-plugin.json; update both occurrences
of that key to the same French string, e.g. "Sélectionnez la façon dont vous
souhaitez configurer le nouveau lecteur".
In `@locales/ja/plugin__kubevirt-plugin.json`:
- Line 1661: The Japanese locale contains English entries for the modal text
("Select how you would like to set up the new drive")—replace the English value
with the correct Japanese translation in the ja locale JSON for the same key(s)
so the CD-ROM modal is fully localized; update both occurrences of that string
(the duplicate key entries) to the Japanese text and ensure JSON syntax remains
valid and consistent with other translations in plugin__kubevirt-plugin.json.
In `@locales/ko/plugin__kubevirt-plugin.json`:
- Line 1661: Replace the English fallback value for the JSON key "Select how you
would like to set up the new drive" with a Korean translation (e.g., "새 드라이브를
설정하는 방법을 선택하세요") in the ko locale file and commit; also search the same file for
any other English fallback strings (the second occurrence reported) and replace
them with appropriate Korean translations so the Add CD-ROM flow is fully
localized.
In `@locales/zh/plugin__kubevirt-plugin.json`:
- Line 1661: The localization value for the key "Select how you would like to
set up the new drive" is still in English; update the Chinese locale entry in
locales/zh/plugin__kubevirt-plugin.json by replacing the English value with an
appropriate Chinese translation (for example: "选择您想如何设置新的驱动器"), leaving the key
string unchanged and preserving JSON formatting/quoting.
- Line 2000: The Chinese locale entry for the key "To finish adding the CD-ROM
drive, stop and restart the virtual machine." is still English; replace the
English value with a proper Chinese translation such as "要完成添加光驱，请关闭并重新启动虚拟机。"
so the zh locale displays correctly for Chinese users.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 66c10c46-82ef-482f-bfb3-eee8ebf202e4
📒 Files selected for processing (8)
locales/en/plugin__kubevirt-plugin.jsonlocales/es/plugin__kubevirt-plugin.jsonlocales/fr/plugin__kubevirt-plugin.jsonlocales/ja/plugin__kubevirt-plugin.jsonlocales/ko/plugin__kubevirt-plugin.jsonlocales/zh/plugin__kubevirt-plugin.jsonsrc/utils/components/DiskModal/AddCDROMModal.tsxsrc/views/virtualmachines/details/tabs/configuration/storage/utils/constants.ts
| "Select cluster...": "Sélectionner un cluster...", | ||
| "Select console type": "Sélectionner le type de console", | ||
| "Select different Node": "Sélectionnez un nœud différent", | ||
| "Select how you would like to set up the new drive": "Select how you would like to set up the new drive", |
There was a problem hiding this comment.
Translate the new FR locale entries before merge.
Line 1685 and Line 2028 currently keep English values in the French locale file, which will surface untranslated UI copy.
💬 Suggested translation update
- "Select how you would like to set up the new drive": "Select how you would like to set up the new drive",
+ "Select how you would like to set up the new drive": "Sélectionnez comment vous souhaitez configurer le nouveau lecteur",
...
- "To finish adding the CD-ROM drive, stop and restart the virtual machine.": "To finish adding the CD-ROM drive, stop and restart the virtual machine.",
+ "To finish adding the CD-ROM drive, stop and restart the virtual machine.": "Pour terminer l’ajout du lecteur CD-ROM, arrêtez puis redémarrez la machine virtuelle.",Also applies to: 2028-2028
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@locales/fr/plugin__kubevirt-plugin.json` at line 1685, Replace the English
value for the JSON key "Select how you would like to set up the new drive" in
the French locale with a proper French translation in
locales/fr/plugin__kubevirt-plugin.json; update both occurrences of that key to
the same French string, e.g. "Sélectionnez la façon dont vous souhaitez
configurer le nouveau lecteur".
| "Select cluster...": "クラスターの選択...", | ||
| "Select console type": "コンソールタイプの選択", | ||
| "Select different Node": "別のノードの選択", | ||
| "Select how you would like to set up the new drive": "Select how you would like to set up the new drive", |
There was a problem hiding this comment.
Localize new JA entries to avoid mixed-language modal content.
Line 1661 and Line 2000 are still English in the Japanese locale file, so users will see inconsistent language in the updated CD-ROM modal text.
🌐 Suggested JA localization patch
- "Select how you would like to set up the new drive": "Select how you would like to set up the new drive",
+ "Select how you would like to set up the new drive": "新しいドライブの設定方法を選択してください",
...
- "To finish adding the CD-ROM drive, stop and restart the virtual machine.": "To finish adding the CD-ROM drive, stop and restart the virtual machine.",
+ "To finish adding the CD-ROM drive, stop and restart the virtual machine.": "CD-ROM ドライブの追加を完了するには、仮想マシンを停止して再起動してください。",Also applies to: 2000-2000
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@locales/ja/plugin__kubevirt-plugin.json` at line 1661, The Japanese locale
contains English entries for the modal text ("Select how you would like to set
up the new drive")—replace the English value with the correct Japanese
translation in the ja locale JSON for the same key(s) so the CD-ROM modal is
fully localized; update both occurrences of that string (the duplicate key
entries) to the Japanese text and ensure JSON syntax remains valid and
consistent with other translations in plugin__kubevirt-plugin.json.
| "Select cluster...": "클러스터 선택...", | ||
| "Select console type": "콘솔 유형 선택", | ||
| "Select different Node": "다른 노드 선택", | ||
| "Select how you would like to set up the new drive": "Select how you would like to set up the new drive", |
There was a problem hiding this comment.
Localize new KO entries instead of shipping English fallback text.
Line 1661 and Line 2000 currently keep English values in the Korean locale, which will show mixed-language UI in the Add CD-ROM flow.
🌐 Suggested KO localization patch
- "Select how you would like to set up the new drive": "Select how you would like to set up the new drive",
+ "Select how you would like to set up the new drive": "새 드라이브를 설정할 방법을 선택하세요",
...
- "To finish adding the CD-ROM drive, stop and restart the virtual machine.": "To finish adding the CD-ROM drive, stop and restart the virtual machine.",
+ "To finish adding the CD-ROM drive, stop and restart the virtual machine.": "CD-ROM 드라이브 추가를 완료하려면 가상 머신을 중지한 후 다시 시작하세요.",Also applies to: 2000-2000
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@locales/ko/plugin__kubevirt-plugin.json` at line 1661, Replace the English
fallback value for the JSON key "Select how you would like to set up the new
drive" with a Korean translation (e.g., "새 드라이브를 설정하는 방법을 선택하세요") in the ko
locale file and commit; also search the same file for any other English fallback
strings (the second occurrence reported) and replace them with appropriate
Korean translations so the Add CD-ROM flow is fully localized.
| "Select cluster...": "选择集群...", | ||
| "Select console type": "选择控制台类型", | ||
| "Select different Node": "选择不同的节点", | ||
| "Select how you would like to set up the new drive": "Select how you would like to set up the new drive", |
There was a problem hiding this comment.
Missing Chinese translation for new localization entry.
The Chinese locale file contains English text instead of a Chinese translation. This will display English to users who have selected the Chinese language, degrading the user experience.
Please provide a proper Chinese translation for this entry.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@locales/zh/plugin__kubevirt-plugin.json` at line 1661, The localization value
for the key "Select how you would like to set up the new drive" is still in
English; update the Chinese locale entry in
locales/zh/plugin__kubevirt-plugin.json by replacing the English value with an
appropriate Chinese translation (for example: "选择您想如何设置新的驱动器"), leaving the key
string unchanged and preserving JSON formatting/quoting.
| "To edit this template, contact your administrator.": "要编辑此模板，请联系您的管理员。", | ||
| "To enable Quick create button, fill all the required parameters and storage fields": "要启用 Quick create 按钮，请填写所有所需的参数和存储字段", | ||
| "To enable this feature, you need to enable the Passt feature flag in the cluster settings.": "要启用此功能，您需要在集群设置中启用 Passt 功能标记。", | ||
| "To finish adding the CD-ROM drive, stop and restart the virtual machine.": "To finish adding the CD-ROM drive, stop and restart the virtual machine.", |
There was a problem hiding this comment.
Missing Chinese translation for new localization entry.
The Chinese locale file contains English text instead of a Chinese translation. This will display English to users who have selected the Chinese language, degrading the user experience.
Please provide a proper Chinese translation for this entry.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@locales/zh/plugin__kubevirt-plugin.json` at line 2000, The Chinese locale
entry for the key "To finish adding the CD-ROM drive, stop and restart the
virtual machine." is still English; replace the English value with a proper
Chinese translation such as "要完成添加光驱，请关闭并重新启动虚拟机。" so the zh locale displays
correctly for Chinese users.
batyana
force-pushed
the
CNV-81184-change-wording-in-modal
branch
from
d22afd6 to
6b8368f
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (2)
locales/ja/plugin__kubevirt-plugin.json (1)
1661-1661:⚠️ Potential issue | 🟡 MinorTranslate the new JA CD-ROM modal strings to avoid mixed-language UI.
Line 1661 and Line 2000 still use English values in the Japanese locale file.
🌐 Suggested JA localization patch
- "Select how you would like to set up the new drive": "Select how you would like to set up the new drive", + "Select how you would like to set up the new drive": "新しいドライブの設定方法を選択してください", ... - "To finish adding the CD-ROM drive restart the virtual machine.": "To finish adding the CD-ROM drive restart the virtual machine.", + "To finish adding the CD-ROM drive restart the virtual machine.": "CD-ROM ドライブの追加を完了するには、仮想マシンを再起動してください。",Also applies to: 2000-2000
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@locales/ja/plugin__kubevirt-plugin.json` at line 1661, The Japanese locale file contains English values for CD-ROM modal strings; update the value for the key "Select how you would like to set up the new drive" (and the other English string at the same locale file around the second occurrence reported) to their proper Japanese translations so the UI is fully localized; locate those keys in locales/ja/plugin__kubevirt-plugin.json (the JSON entries currently mapping English text to English) and replace the right-hand side strings with the appropriate Japanese translations while preserving the JSON key structure and punctuation.locales/ko/plugin__kubevirt-plugin.json (1)
1661-1661:⚠️ Potential issue | 🟡 MinorLocalize the new KO CD-ROM strings instead of keeping English fallback text.
Line 1661 and Line 2000 are still English in the Korean locale, so the modal will render mixed-language content.
🌐 Suggested KO localization patch
- "Select how you would like to set up the new drive": "Select how you would like to set up the new drive", + "Select how you would like to set up the new drive": "새 드라이브를 설정할 방법을 선택하세요", ... - "To finish adding the CD-ROM drive restart the virtual machine.": "To finish adding the CD-ROM drive restart the virtual machine.", + "To finish adding the CD-ROM drive restart the virtual machine.": "CD-ROM 드라이브 추가를 완료하려면 가상 머신을 다시 시작하세요.",Also applies to: 2000-2000
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@locales/ko/plugin__kubevirt-plugin.json` at line 1661, Replace the English fallback strings in the Korean locale for the CD-ROM modal: find the entries whose value is "Select how you would like to set up the new drive" (and the second duplicate occurrence) in locales/ko/plugin__kubevirt-plugin.json and replace them with the proper Korean translation, ensuring both occurrences are updated consistently and file formatting/linting is preserved; verify the modal renders fully localized Korean.
🧹 Nitpick comments (1)
src/utils/components/DiskModal/AddCDROMModal.tsx (1)
148-150: Grammar issue in restart message.The message text is missing a comma, which makes it slightly harder to read. Consider adding punctuation for clarity.
✏️ Suggested fix
<PendingChangesAlert title={t('Restart required')}> - {t('To finish adding the CD-ROM drive restart the virtual machine.')} + {t('To finish adding the CD-ROM drive, restart the virtual machine.')} </PendingChangesAlert>Note: This change would also need to be applied to all locale files.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/utils/components/DiskModal/AddCDROMModal.tsx` around lines 148 - 150, The restart message inside PendingChangesAlert is missing a comma; update the translation string used in AddCDROMModal (the t(...) key currently rendering "To finish adding the CD-ROM drive restart the virtual machine.") to include a comma after "drive" (e.g., "To finish adding the CD-ROM drive, restart the virtual machine.") and propagate the same punctuation change to all corresponding locale translation entries so all languages reflect the corrected grammar.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@locales/fr/plugin__kubevirt-plugin.json`:
- Line 2028: The locale entry with value "To finish adding the CD-ROM drive
restart the virtual machine." is both grammatically wrong and untranslated in
the French file; update the English source string to include the comma ("To
finish adding the CD-ROM drive, restart the virtual machine." or the intended
variant "To finish adding the CD-ROM drive, stop and restart the virtual
machine."), and replace the French value for that key with a proper French
translation (e.g., "Pour terminer l’ajout du lecteur CD-ROM, redémarrez la
machine virtuelle."), then apply equivalent corrected translations to the other
locale files (es, ja, ko, zh) to ensure consistency for the string "To finish
adding the CD-ROM drive restart the virtual machine." referenced in
plugin__kubevirt-plugin.json.
---
Duplicate comments:
In `@locales/ja/plugin__kubevirt-plugin.json`:
- Line 1661: The Japanese locale file contains English values for CD-ROM modal
strings; update the value for the key "Select how you would like to set up the
new drive" (and the other English string at the same locale file around the
second occurrence reported) to their proper Japanese translations so the UI is
fully localized; locate those keys in locales/ja/plugin__kubevirt-plugin.json
(the JSON entries currently mapping English text to English) and replace the
right-hand side strings with the appropriate Japanese translations while
preserving the JSON key structure and punctuation.
In `@locales/ko/plugin__kubevirt-plugin.json`:
- Line 1661: Replace the English fallback strings in the Korean locale for the
CD-ROM modal: find the entries whose value is "Select how you would like to set
up the new drive" (and the second duplicate occurrence) in
locales/ko/plugin__kubevirt-plugin.json and replace them with the proper Korean
translation, ensuring both occurrences are updated consistently and file
formatting/linting is preserved; verify the modal renders fully localized
Korean.
---
Nitpick comments:
In `@src/utils/components/DiskModal/AddCDROMModal.tsx`:
- Around line 148-150: The restart message inside PendingChangesAlert is missing
a comma; update the translation string used in AddCDROMModal (the t(...) key
currently rendering "To finish adding the CD-ROM drive restart the virtual
machine.") to include a comma after "drive" (e.g., "To finish adding the CD-ROM
drive, restart the virtual machine.") and propagate the same punctuation change
to all corresponding locale translation entries so all languages reflect the
corrected grammar.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 18a7ec69-b161-48b6-9793-09262ce44606
📒 Files selected for processing (8)
locales/en/plugin__kubevirt-plugin.jsonlocales/es/plugin__kubevirt-plugin.jsonlocales/fr/plugin__kubevirt-plugin.jsonlocales/ja/plugin__kubevirt-plugin.jsonlocales/ko/plugin__kubevirt-plugin.jsonlocales/zh/plugin__kubevirt-plugin.jsonsrc/utils/components/DiskModal/AddCDROMModal.tsxsrc/views/virtualmachines/details/tabs/configuration/storage/utils/constants.ts
🚧 Files skipped from review as they are similar to previous changes (3)
- locales/es/plugin__kubevirt-plugin.json
- src/views/virtualmachines/details/tabs/configuration/storage/utils/constants.ts
- locales/en/plugin__kubevirt-plugin.json
| "To edit this template, contact your administrator.": "Pour modifier ce modèle, contactez votre administrateur.", | ||
| "To enable Quick create button, fill all the required parameters and storage fields": "Pour activer le bouton de création rapide, remplissez tous les paramètres et champs de stockage requis", | ||
| "To enable this feature, you need to enable the Passt feature flag in the cluster settings.": "Pour activer cette fonctionnalité, vous devez activer l’indicateur de fonctionnalité Passt dans les paramètres du cluster.", | ||
| "To finish adding the CD-ROM drive restart the virtual machine.": "To finish adding the CD-ROM drive restart the virtual machine.", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# First, let's read the file around line 2028 to see the exact content
cat -n locales/fr/plugin__kubevirt-plugin.json | sed -n '2025,2035p'Repository: kubevirt-ui/kubevirt-plugin
Length of output: 2004
🏁 Script executed:
# Let's also check the total lines and structure of the file
wc -l locales/fr/plugin__kubevirt-plugin.jsonRepository: kubevirt-ui/kubevirt-plugin
Length of output: 115
🏁 Script executed:
# Search for this translation key in other locale files
rg "To finish adding the CD-ROM drive" locales/Repository: kubevirt-ui/kubevirt-plugin
Length of output: 1114
🏁 Script executed:
# Check if there are any other similar CD-ROM related translations
rg "CD-ROM" locales/ -A 1 -B 1Repository: kubevirt-ui/kubevirt-plugin
Length of output: 37629
Missing translations and grammatical issue across all locale files.
Line 2028 has two issues:
-
Missing translations: All locale files (en, es, fr, ja, ko, zh) have English text as the value instead of proper translations. The French file should have a French translation.
-
Grammatical error in English source: The text is missing a comma after "drive". It should read "To finish adding the CD-ROM drive, restart the virtual machine." (or if the design intent matches the PR description, "To finish adding the CD-ROM drive, stop and restart the virtual machine.").
All six locale files need correction to ensure consistency.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@locales/fr/plugin__kubevirt-plugin.json` at line 2028, The locale entry with
value "To finish adding the CD-ROM drive restart the virtual machine." is both
grammatically wrong and untranslated in the French file; update the English
source string to include the comma ("To finish adding the CD-ROM drive, restart
the virtual machine." or the intended variant "To finish adding the CD-ROM
drive, stop and restart the virtual machine."), and replace the French value for
that key with a proper French translation (e.g., "Pour terminer l’ajout du
lecteur CD-ROM, redémarrez la machine virtuelle."), then apply equivalent
corrected translations to the other locale files (es, ja, ko, zh) to ensure
consistency for the string "To finish adding the CD-ROM drive restart the
virtual machine." referenced in plugin__kubevirt-plugin.json.
|
/approve |
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: batyana, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
src/views/virtualmachines/details/tabs/configuration/storage/utils/constants.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: batyana <bnahmias@redhat.com>
batyana
force-pushed
the
CNV-81184-change-wording-in-modal
branch
from
6b8368f to
0b84877
Compare
|
@batyana: This pull request references CNV-81184 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Actionable comments posted: 4
♻️ Duplicate comments (1)
locales/zh/plugin__kubevirt-plugin.json (1)
1661-1661:⚠️ Potential issue | 🟡 MinorUntranslated zh locale values remain for the new CD-ROM copy.
Line 1661 and Line 2002 still use English values in the Chinese locale, so Chinese users will see mixed-language UI.
🌐 Suggested translation fix
- "Select how you would like to set up the new drive": "Select how you would like to set up the new drive", + "Select how you would like to set up the new drive": "请选择您希望如何设置新驱动器", ... - "To finish adding the CD-ROM drive restart the virtual machine.": "To finish adding the CD-ROM drive restart the virtual machine.", + "To finish adding the CD-ROM drive restart the virtual machine.": "要完成添加 CD-ROM 驱动器，请重启虚拟机。",Also applies to: 2002-2002
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@locales/zh/plugin__kubevirt-plugin.json` at line 1661, The Chinese locale contains an untranslated string for the JSON key "Select how you would like to set up the new drive"; replace the English value with a proper Chinese translation (e.g., "选择设置新光驱的方式" or your preferred phrasing) and update the same key wherever it appears (both occurrences) so the zh locale is fully translated and consistent.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@locales/en/plugin__kubevirt-plugin.json`:
- Line 2010: Update the locale entry whose value is "To finish adding the CD-ROM
drive restart the virtual machine." (in plugin__kubevirt-plugin.json) to include
the missing comma after "drive" so it reads "To finish adding the CD-ROM drive,
restart the virtual machine."; also confirm whether the mockup's wording ("To
finish adding the CD-ROM drive, stop and restart the virtual machine.") should
replace the current string and if so, update that same locale value accordingly
to match the design.
In `@locales/es/plugin__kubevirt-plugin.json`:
- Around line 1950-1951: Replace the English values for the two translation keys
with Spanish translations: for key "The ISO has been uploaded successfully." set
the value to "El ISO se ha subido correctamente." and for key "The ISO upload
failed. Check the DataVolume status for details." set the value to "La carga del
ISO ha fallado. Comprueba el estado del DataVolume para más detalles."; update
these values in locales/es/plugin__kubevirt-plugin.json where those exact keys
appear (also apply the same replacements at the other occurrence mentioned).
- Line 2087: Replace the English upload-status values with Spanish translations
for the affected translation keys (e.g., update the "Upload completed" value and
the other upload-related keys at the same section such as the entries at the
positions referenced around lines 2091 and 2335) by replacing the English
strings with appropriate Spanish text (for example "Upload completed" -> "Carga
completada"), ensuring all upload/status-related JSON values in
plugin__kubevirt-plugin.json are translated to Spanish and keep the original
keys unchanged.
In `@locales/zh/plugin__kubevirt-plugin.json`:
- Around line 1924-1925: The Chinese locale file contains untranslated English
strings—specifically the keys/values "The ISO has been uploaded successfully."
and "The ISO upload failed. Check the DataVolume status for details."—so replace
their English values with proper Chinese translations (and likewise update the
other occurrences noted: the identical strings at the other entries) to ensure
consistent UX; locate these exact string literals in
plugin__kubevirt-plugin.json and provide accurate Chinese translations for each
entry.
---
Duplicate comments:
In `@locales/zh/plugin__kubevirt-plugin.json`:
- Line 1661: The Chinese locale contains an untranslated string for the JSON key
"Select how you would like to set up the new drive"; replace the English value
with a proper Chinese translation (e.g., "选择设置新光驱的方式" or your preferred
phrasing) and update the same key wherever it appears (both occurrences) so the
zh locale is fully translated and consistent.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 2daf78ec-dca0-4231-874e-08803ea67739
📒 Files selected for processing (8)
locales/en/plugin__kubevirt-plugin.jsonlocales/es/plugin__kubevirt-plugin.jsonlocales/fr/plugin__kubevirt-plugin.jsonlocales/ja/plugin__kubevirt-plugin.jsonlocales/ko/plugin__kubevirt-plugin.jsonlocales/zh/plugin__kubevirt-plugin.jsonsrc/utils/components/DiskModal/AddCDROMModal.tsxsrc/views/virtualmachines/details/tabs/configuration/storage/utils/constants.ts
✅ Files skipped from review due to trivial changes (1)
- locales/ja/plugin__kubevirt-plugin.json
🚧 Files skipped from review as they are similar to previous changes (4)
- locales/ko/plugin__kubevirt-plugin.json
- src/views/virtualmachines/details/tabs/configuration/storage/utils/constants.ts
- locales/fr/plugin__kubevirt-plugin.json
- src/utils/components/DiskModal/AddCDROMModal.tsx
| "To edit this template, contact your administrator.": "To edit this template, contact your administrator.", | ||
| "To enable Quick create button, fill all the required parameters and storage fields": "To enable Quick create button, fill all the required parameters and storage fields", | ||
| "To enable this feature, you need to enable the Passt feature flag in the cluster settings.": "To enable this feature, you need to enable the Passt feature flag in the cluster settings.", | ||
| "To finish adding the CD-ROM drive restart the virtual machine.": "To finish adding the CD-ROM drive restart the virtual machine.", |
There was a problem hiding this comment.
Missing comma in user-facing text.
There should be a comma after "drive" for correct punctuation: "To finish adding the CD-ROM drive**,** restart the virtual machine."
Additionally, the PR mockup screenshot shows "To finish adding the CD-ROM drive, stop and restart the virtual machine." — please confirm whether "stop and" was intentionally omitted or if it should be included to match the design.
Suggested fix (comma only)
- "To finish adding the CD-ROM drive restart the virtual machine.": "To finish adding the CD-ROM drive restart the virtual machine.",
+ "To finish adding the CD-ROM drive, restart the virtual machine.": "To finish adding the CD-ROM drive, restart the virtual machine.",Alternative fix (matching mockup)
- "To finish adding the CD-ROM drive restart the virtual machine.": "To finish adding the CD-ROM drive restart the virtual machine.",
+ "To finish adding the CD-ROM drive, stop and restart the virtual machine.": "To finish adding the CD-ROM drive, stop and restart the virtual machine.",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "To finish adding the CD-ROM drive restart the virtual machine.": "To finish adding the CD-ROM drive restart the virtual machine.", | |
| "To finish adding the CD-ROM drive, restart the virtual machine.": "To finish adding the CD-ROM drive, restart the virtual machine.", |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@locales/en/plugin__kubevirt-plugin.json` at line 2010, Update the locale
entry whose value is "To finish adding the CD-ROM drive restart the virtual
machine." (in plugin__kubevirt-plugin.json) to include the missing comma after
"drive" so it reads "To finish adding the CD-ROM drive, restart the virtual
machine."; also confirm whether the mockup's wording ("To finish adding the
CD-ROM drive, stop and restart the virtual machine.") should replace the current
string and if so, update that same locale value accordingly to match the design.
| "The ISO has been uploaded successfully.": "The ISO has been uploaded successfully.", | ||
| "The ISO upload failed. Check the DataVolume status for details.": "The ISO upload failed. Check the DataVolume status for details.", |
There was a problem hiding this comment.
Missing Spanish translations for ISO and CD-ROM messages.
These newly added translation entries contain English text instead of Spanish translations. Spanish-speaking users will see English text for these specific strings.
🌐 Suggested Spanish translations
- "The ISO has been uploaded successfully.": "The ISO has been uploaded successfully.",
+ "The ISO has been uploaded successfully.": "El archivo ISO se ha cargado correctamente.",- "The ISO upload failed. Check the DataVolume status for details.": "The ISO upload failed. Check the DataVolume status for details.",
+ "The ISO upload failed. Check the DataVolume status for details.": "La carga del ISO falló. Compruebe el estado de DataVolume para obtener más detalles.",- "To finish adding the CD-ROM drive restart the virtual machine.": "To finish adding the CD-ROM drive restart the virtual machine.",
+ "To finish adding the CD-ROM drive restart the virtual machine.": "Para finalizar la adición de la unidad de CD-ROM, reinicie la máquina virtual.",Also applies to: 2030-2030
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@locales/es/plugin__kubevirt-plugin.json` around lines 1950 - 1951, Replace
the English values for the two translation keys with Spanish translations: for
key "The ISO has been uploaded successfully." set the value to "El ISO se ha
subido correctamente." and for key "The ISO upload failed. Check the DataVolume
status for details." set the value to "La carga del ISO ha fallado. Comprueba el
estado del DataVolume para más detalles."; update these values in
locales/es/plugin__kubevirt-plugin.json where those exact keys appear (also
apply the same replacements at the other occurrence mentioned).
| "Upload a new file to a PVC. A new PVC will be created.": "Cargar un nuevo archivo a una PVC. Se creará una nueva PVC.", | ||
| "Upload canceled": "Se canceló la carga", | ||
| "Upload cancelled": "Se canceló la carga", | ||
| "Upload completed": "Upload completed", |
There was a problem hiding this comment.
Missing Spanish translations for upload status messages.
These upload-related translation entries retain English text instead of providing Spanish translations.
🌐 Suggested Spanish translations
- "Upload completed": "Upload completed",
+ "Upload completed": "Carga completada",- "Upload failed": "Upload failed",
+ "Upload failed": "Carga fallida",- "You can navigate away. The upload will continue in the background.": "You can navigate away. The upload will continue in the background.",
+ "You can navigate away. The upload will continue in the background.": "Puede navegar a otra página. La carga continuará en segundo plano.",Also applies to: 2091-2091, 2335-2335
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@locales/es/plugin__kubevirt-plugin.json` at line 2087, Replace the English
upload-status values with Spanish translations for the affected translation keys
(e.g., update the "Upload completed" value and the other upload-related keys at
the same section such as the entries at the positions referenced around lines
2091 and 2335) by replacing the English strings with appropriate Spanish text
(for example "Upload completed" -> "Carga completada"), ensuring all
upload/status-related JSON values in plugin__kubevirt-plugin.json are translated
to Spanish and keep the original keys unchanged.
| "The ISO has been uploaded successfully.": "The ISO has been uploaded successfully.", | ||
| "The ISO upload failed. Check the DataVolume status for details.": "The ISO upload failed. Check the DataVolume status for details.", |
There was a problem hiding this comment.
New upload-status strings are still untranslated in zh.
These newly added entries are English values in the Chinese file and should be localized to avoid inconsistent UX.
🌐 Suggested translation fix
- "The ISO has been uploaded successfully.": "The ISO has been uploaded successfully.",
+ "The ISO has been uploaded successfully.": "ISO 已成功上传。",
- "The ISO upload failed. Check the DataVolume status for details.": "The ISO upload failed. Check the DataVolume status for details.",
+ "The ISO upload failed. Check the DataVolume status for details.": "ISO 上传失败。请检查 DataVolume 状态以了解详细信息。",
...
- "Upload completed": "Upload completed",
+ "Upload completed": "上传完成",
- "Upload failed": "Upload failed",
+ "Upload failed": "上传失败",
...
- "You can navigate away. The upload will continue in the background.": "You can navigate away. The upload will continue in the background.",
+ "You can navigate away. The upload will continue in the background.": "您可以离开此页面。上传将在后台继续。",Also applies to: 2059-2059, 2063-2063, 2307-2307
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@locales/zh/plugin__kubevirt-plugin.json` around lines 1924 - 1925, The
Chinese locale file contains untranslated English strings—specifically the
keys/values "The ISO has been uploaded successfully." and "The ISO upload
failed. Check the DataVolume status for details."—so replace their English
values with proper Chinese translations (and likewise update the other
occurrences noted: the identical strings at the other entries) to ensure
consistent UX; locate these exact string literals in
plugin__kubevirt-plugin.json and provide accurate Chinese translations for each
entry.
| body: t('The ISO upload failed. Check the DataVolume status for details.'), | ||
| title: t('Upload failed'), |
There was a problem hiding this comment.
I checked and this is after all translated here: https://github.com/kubevirt-ui/kubevirt-plugin/blob/main/src/views/virtualmachines/details/tabs/configuration/storage/StorageTab.tsx#L41
So we shouldn't wrap the strings in the t function here, because this would result to calling t with the already translated string.
But we can provide comments like // t('The ISO upload failed. Check the DataVolume status for details.') to generate the translations (maybe we already have them somewhere, so add a comment for the new string)
|
@batyana: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
📝 Description
changing the wording according to new design
🎥 Demo
Summary by CodeRabbit
New Features
Bug Fixes
Documentation