Skip to content

Solve G115 Linter Errors#4193

Open
HoustonBoston wants to merge 1 commit into
kubevirt:mainfrom
HoustonBoston:fix-g115-linting
Open

Solve G115 Linter Errors#4193
HoustonBoston wants to merge 1 commit into
kubevirt:mainfrom
HoustonBoston:fix-g115-linting

Conversation

@HoustonBoston

@HoustonBoston HoustonBoston commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Rather than excluding G115 for linting globally, this fix evaluates type conversions on a case-by-case basis, changing types of variables and completely ignoring the integer conversion where applicable so that linting succeeds.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3656.

Special notes for your reviewer:

Release note:

NONE

@kubevirt-prow kubevirt-prow Bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jul 1, 2026
@kubevirt-prow kubevirt-prow Bot requested review from akalenyu and alromeros July 1, 2026 20:25
@kubevirt-prow

kubevirt-prow Bot commented Jul 1, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign awels for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-prow

kubevirt-prow Bot commented Jul 1, 2026

Copy link
Copy Markdown

Hi @HoustonBoston. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dsanatar

dsanatar commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

/test all

@coveralls

coveralls commented Jul 2, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 49.826% (+0.04%) from 49.79% — HoustonBoston:fix-g115-linting into kubevirt:main

…nd added nolint:gosec declarative if it required more work

Signed-off-by: HoustonBoston <rorajesh@redhat.com>
@dsanatar

dsanatar commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

/test all

@HoustonBoston

Copy link
Copy Markdown
Contributor Author

/test pull-containerized-data-importer-e2e-s390x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Evaluate G115 linter errors

3 participants