Solve G115 Linter Errors#4193
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @HoustonBoston. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
e6bf22c to
438cf37
Compare
438cf37 to
291082e
Compare
|
/test all |
291082e to
8162e58
Compare
…nd added nolint:gosec declarative if it required more work Signed-off-by: HoustonBoston <rorajesh@redhat.com>
8162e58 to
a5460e3
Compare
|
/test all |
|
/test pull-containerized-data-importer-e2e-s390x |
What this PR does / why we need it:
Rather than excluding G115 for linting globally, this fix evaluates type conversions on a case-by-case basis, changing types of variables and completely ignoring the integer conversion where applicable so that linting succeeds.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #3656.
Special notes for your reviewer:
Release note: