Fix kubevirt_memory_delta_from_requested_bytes to the new name, and upgrade metrics linter #4123
Fix kubevirt_memory_delta_from_requested_bytes to the new name, and upgrade metrics linter #4123avlitman wants to merge 2 commits intokubevirt:mainfrom
Conversation
kubevirt-bot
added
release-note-none
|
/hold until kubevirt/kubevirt#17065 is merged |
kubevirt-bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- With the switch to
container:kubevirt_memory_delta_from_requested_bytes:max, ensure the metric still exposescontainerandreasonlabels; if the label set differs from the deprecated metric, thesum by (container, reason)expression may need to be adjusted accordingly. - Now that
excludedMetricsis always empty, consider removing the map entirely or documenting when and how entries should be added in the future to avoid dead or confusing configuration.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- With the switch to `container:kubevirt_memory_delta_from_requested_bytes:max`, ensure the metric still exposes `container` and `reason` labels; if the label set differs from the deprecated metric, the `sum by (container, reason)` expression may need to be adjusted accordingly.
- Now that `excludedMetrics` is always empty, consider removing the map entirely or documenting when and how entries should be added in the future to avoid dead or confusing configuration.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Pull Request Test Coverage Report for Build 23591379017Details
💛 - Coveralls |
|
/unhold |
kubevirt-bot
removed
the
do-not-merge/hold
|
hco-e2e-kv-smoke-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-aws, ci/prow/hco-e2e-kv-smoke-azure, ci/prow/hco-e2e-operator-sdk-aws, ci/prow/hco-e2e-upgrade-operator-sdk-aws, ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws, ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-aws DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
avlitman
changed the title
Signed-off-by: avlitman <alitman@redhat.com> Made-with: Cursor
Signed-off-by: avlitman <alitman@redhat.com>
avlitman
force-pushed
the
fix-cnv-abnormal
branch
from
469cb9c to
4c27da4
Compare
|
|
/hold until hco will be able to get kubevirt version with the fix CC @nunnatsa |
kubevirt-bot
added
the
do-not-merge/hold
|
@avlitman: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
In kubevirt/kubevirt#17065
kubevirt_memory_delta_from_requested_bytesis deprecated and replaced bycontainer:kubevirt_memory_delta_from_requested_bytes:max. This pr fixcnv_abnormalexpression to use the new name.*This pr also upgrade the linter version to be able to remove
cluster:vmi_request_cpu_cores:sumand excluded list.Release note: