Add gemini reviewer bot#148
Conversation
|
/hold until #147 is merged. |
0bb14f7 to
8b56d4d
Compare
|
/gemini review |
1 similar comment
|
/gemini review |
There was a problem hiding this comment.
I asked claude to go back 150 PRs on ipam-ext and extract @maiqueb's reviews in order to synthesize some rules that you could consider adding to your styleguide, in order to help make the PRs attuned to your review style.
Feel free to add some/all/none:
-
Prefer: domain-accurate names that describe the real object or behavior.
Example: UsesecondaryAttachmentNameinstead ofnetworkNamewhen referring to a NAD attachment key. -
Prefer: extracting duplicated setup/build logic into a small helper.
Example: Addfunc dummyVMWithSecondaryNet(...) *kubevirtv1.VirtualMachineinstead of repeating VM spec construction in multiple tests. -
Prefer: named constants for repeated limits and timeouts.
Example: Defineconst vmReadyTimeout = 5 * time.Minuteand reuse it instead of mixing5mand90sliterals. -
Prefer: tests that validate public behavior and outcomes.
Example: Assert webhook behavior (pod admitted/rejected and mutation result) rather than testing private helper internals. -
Prefer: cleanup in teardown blocks, not in scenario flow.
Example: Put resource deletion inAfterEach/DeferCleanuprather than inline insideIt(...). -
Prefer: positive assertions that describe expected success.
Example: UseExpect(k8sClient.Update(ctx, obj)).To(Succeed())instead ofExpect(err).NotTo(HaveOccurred()). -
Prefer: clear Ginkgo narrative (
When/Context/It) that reads like behavior documentation.
Example:
When("persistent IP is disabled on NAD")
It("does not create an IPAMClaim"). -
Prefer: explicit input types over boolean flags in function parameters.
Example: UsecreateClaim(ctx, ClaimModeDryRun)/createClaim(ctx, ClaimModeApply)instead ofcreateClaim(ctx, true).
|
I think gemini-code-assist is already registered for kubevirt org gemini-code-assist are you here with us? %shandalir-shatters% |
I'll use this info on #147, which actually defined the agents file. When I figure out how to onboard gemini into the project, we'll use those guidelines again. Nice suggestion @RamLavi , tks. |
|
Closing until I figure out how to onboard gemini into the kubevirt org. |
|
@maiqueb why not gemini-code-assist? From what I see it's already configured for kubevirt org. |
|
@gemini-code-assist can you evaluate this PR ? |
|
/gemini review |
|
/gemini review ... let's see if this does anything after the repo's got the permissions ... |
|
@gemini-code-assist please review :) |
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
1 similar comment
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a CLAUDE.md file to provide project-specific guidance for AI coding tools, covering build commands, architecture, and design guidelines. Feedback was provided regarding violations of the document's own 120-character line length limit and a potential naming inconsistency between the file name and the pull request metadata.
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
8b56d4d to
0263d04
Compare
|
/gemini review |
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhiller, qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
What this PR does / why we need it:
Adds gemini code reviewer bot to ease the maintainer burden on this repo.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Depends-on: #147
Release note: