centos-stream-10: Fix arm64 and s390x builds#4
Conversation
In CentOS Stream 10, libssh gained a dependency on libfido2 which in turn depends on libcbor and libudev (systemd-libs). The bazeldnf ldd command was not discovering these transitive dependencies because libfido2 was not in the input libs list. Add it to all three CS10 ldd targets and regenerate RPM dependencies so the tar2files targets include libcbor.so and libudev.so, fixing cross-compilation link failures for aarch64 and s390x. Assisted-By: Claude <noreply@anthropic.com> Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
The sandbox_config function hardcoded the platform to x86_64, causing toolchain resolution failures when building on non-x86_64 hosts (e.g. aarch64). Use the HOST_ARCHITECTURE variable already set by the script to select the correct platform. Assisted-By: Claude <noreply@anthropic.com> Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
kubevirt-bot
added
release-note-none
kubevirt-bot
added
the
sig/buildsystem
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jean-edouard, lyarwood The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
lyarwood
changed the title
|
/lgtm |
|
/override check-vep |
|
@lyarwood: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6 participants
What this PR does
Early cherry-pick of kubevirt/kubevirt#16938 that now needs to land on main and be backported to release-1.8 in order to unblock kubevirt/project-infra#4738.
References
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note