OWNERS, OWNERS_ALIASES: scope to forked project contributors#5
Conversation
|
There are empty aliases in OWNER_ALIASES, cleanup is advised. |
1 similar comment
|
There are empty aliases in OWNER_ALIASES, cleanup is advised. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jean-edouard, lyarwood The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reduce OWNERS and OWNERS_ALIASES to only list the five people actively working on this forked project: vladikr, jean-edouard, xpivarc, lyarwood, and fossedihelm. SIG groups that no longer have any members are set to empty arrays so that Prow falls back to the top-level OWNERS for those areas. Assisted-By: Claude <noreply@anthropic.com> Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
|
There are empty aliases in OWNER_ALIASES, cleanup is advised. |
| @@ -115,53 +58,33 @@ aliases: | |||
| # | |||
| sig-compute-approvers: | |||
| - jean-edouard | |||
There was a problem hiding this comment.
@jean-edouard I guess this means we should add you and @vladikr as a sig-compute-reviewers in kubevirt/kubevirt?
There was a problem hiding this comment.
Not all approvers want to be reviewers, but in this case yeah I should be a sig-compute-reviewers (and you a sig-compute-instancetype-reviewers? :) )
There was a problem hiding this comment.
|
/hold cancel |
|
/lgtm |
What this PR does
Before this PR:
OWNERS_ALIASES listed all upstream kubevirt/kubevirt contributors across all SIGs, most of whom are not working on this fork. The OWNERS file also referenced an undefined
emeritus_approversalias.After this PR:
OWNERS and OWNERS_ALIASES are scoped to only the five people actively working on this forked project: vladikr, jean-edouard, xpivarc, lyarwood, and fossedihelm. SIG groups with no remaining members are set to empty arrays so Prow falls back to top-level OWNERS for those areas.
References
Why we need it and why it was done in this way
This fork has a smaller team than upstream kubevirt. Keeping the full upstream OWNERS list means people not working on this project could be assigned reviews or approvals. Scoping to the active contributors ensures correct review routing.
The following tradeoffs were made:
The following alternatives were considered:
Special notes for your reviewer
Coverage gaps to be aware of:
Checklist
Release note