Skip to content

OWNERS, OWNERS_ALIASES: scope to forked project contributors#5

Merged
lyarwood merged 1 commit into
kubevirt:release-1.8-aie-nvfrom
lyarwood:owners
Feb 27, 2026
Merged

OWNERS, OWNERS_ALIASES: scope to forked project contributors#5
lyarwood merged 1 commit into
kubevirt:release-1.8-aie-nvfrom
lyarwood:owners

Conversation

@lyarwood

Copy link
Copy Markdown
Member

What this PR does

Before this PR:

OWNERS_ALIASES listed all upstream kubevirt/kubevirt contributors across all SIGs, most of whom are not working on this fork. The OWNERS file also referenced an undefined emeritus_approvers alias.

After this PR:

OWNERS and OWNERS_ALIASES are scoped to only the five people actively working on this forked project: vladikr, jean-edouard, xpivarc, lyarwood, and fossedihelm. SIG groups with no remaining members are set to empty arrays so Prow falls back to top-level OWNERS for those areas.

References

Why we need it and why it was done in this way

This fork has a smaller team than upstream kubevirt. Keeping the full upstream OWNERS list means people not working on this project could be assigned reviews or approvals. Scoping to the active contributors ensures correct review routing.

The following tradeoffs were made:

  • Several SIGs (Network, Storage, Observability, Scale) now have empty reviewer/approver lists. Reviews for those areas will fall back to the top-level OWNERS (approvers: vladikr, jean-edouard, xpivarc; reviewers: lyarwood, fossedihelm).

The following alternatives were considered:

  • Removing the empty SIG groups entirely, but keeping them as empty arrays avoids breaking any sub-directory OWNERS files that reference those aliases.

Special notes for your reviewer

Coverage gaps to be aware of:

  • No dedicated owners: Network, Storage, Observability, Scale (fall back to top-level)
  • Single person in both roles: SIG Test and SIG Buildsystem (xpivarc only)
  • No reviewers: SIG Compute Instance types (lyarwood is sole approver)

Checklist

Release note

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. size/L labels Feb 27, 2026
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Feb 27, 2026
@kubevirt-bot

Copy link
Copy Markdown
Contributor

There are empty aliases in OWNER_ALIASES, cleanup is advised.

1 similar comment
@kubevirt-bot

Copy link
Copy Markdown
Contributor

There are empty aliases in OWNER_ALIASES, cleanup is advised.

@fossedihelm

Copy link
Copy Markdown
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2026
Comment thread OWNERS_ALIASES
@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2026
@kubevirt-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jean-edouard, lyarwood

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2026
Reduce OWNERS and OWNERS_ALIASES to only list the five people
actively working on this forked project: vladikr, jean-edouard,
xpivarc, lyarwood, and fossedihelm.

SIG groups that no longer have any members are set to empty arrays
so that Prow falls back to the top-level OWNERS for those areas.

Assisted-By: Claude <noreply@anthropic.com>
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2026
@kubevirt-bot

Copy link
Copy Markdown
Contributor

There are empty aliases in OWNER_ALIASES, cleanup is advised.

Comment thread OWNERS_ALIASES
@@ -115,53 +58,33 @@ aliases:
#
sig-compute-approvers:
- jean-edouard

@lyarwood lyarwood Feb 27, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jean-edouard I guess this means we should add you and @vladikr as a sig-compute-reviewers in kubevirt/kubevirt?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all approvers want to be reviewers, but in this case yeah I should be a sig-compute-reviewers (and you a sig-compute-instancetype-reviewers? :) )

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lyarwood

Copy link
Copy Markdown
Member Author

/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2026
@fossedihelm

Copy link
Copy Markdown
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2026
@lyarwood lyarwood merged commit 5c3a0f0 into kubevirt:release-1.8-aie-nv Feb 27, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants