Closed
Conversation
follow-up for this pr: kubevirt/kubevirt#13911 Signed-off-by: avlitman <alitman@redhat.com>
kubevirt-bot
added
the
dco-signoff: yes
kubevirt-bot
added
size/XS
dco-signoff: no
Fix all deprecated runbooks content to this template: # <alert-name> [Deprecated] This alert has been deprecated; it does not indicate a genuine issue. If triggered, it may be safely ignored and silenced. Signed-off-by: avlitman <alitman@redhat.com>
avlitman
force-pushed
the
deprecate-high-alerts
branch
from
488570e to
1cea69b
Compare
kubevirt-bot
added
dco-signoff: yes
Collaborator
|
Hi @avlitman, I think we should add the deprecation notice at the top of the runbooks, but not remove all the runbooks content. |
Collaborator
|
Hi @avlitman , please see my comment above |
Collaborator
|
@avlitman waiting for the update before I can merge |
kubevirt-bot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Collaborator
|
@avlitman please update |
Collaborator
|
Closing in favor of #311 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up for this pr: kubevirt/kubevirt#13911
This pr also Fix all deprecated runbooks content to this template:
Release note: