Update Dockerfile to use TARGETOS instead of linux.#289
Merged
nunnatsa merged 1 commit intokubevirt:mainfrom Apr 29, 2025
Merged
Update Dockerfile to use TARGETOS instead of linux.#289nunnatsa merged 1 commit intokubevirt:mainfrom
nunnatsa merged 1 commit intokubevirt:mainfrom
Conversation
This modification ensures that the image can be built for various operating systems, not just Linux, by utilizing the appropriate platform variables during the build process. Signed-off-by: Ashok Pariya <ashok.pariya@ibm.com>
8 tasks
nunnatsa
reviewed
Apr 29, 2025
nunnatsa
approved these changes
Apr 29, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Apr 29, 2025
Update Dockerfile to use TARGETOS instead of linux.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modification ensures that the image can be built for various operating systems, not just Linux, by utilizing the appropriate platform variables during the build process.
What this PR does / why we need it:
This PR updates the Dockerfile to dynamically reference the platform architecture using the ${TARGETOS} and ${TARGETARCH} variables instead of the hardcoded linux platform. This change makes the Dockerfile more flexible and adaptable for building images across different operating systems and architectures
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: