DRAFT: Configure mtu#2
Draft
bgartzi wants to merge 2 commits into
Draft
Conversation
kubevirt-bot
added
do-not-merge/work-in-progress
Contributor
Author
|
Rebased onto #3 (it now depends on it) as it makes the implementation cleaner. |
While on it, also bump kubevirt.io/{api,client-go} so everything fits.
Signed-off-by: Beñat Gartzia Arruabarrena <bgartzia@redhat.com>
Contributor
Author
|
Now kubevirt is bumped onto the latest available upstream instead of the personal fork containing the mtu downwardapi patch. Libvirt still does not support setting |
Signed-off-by: Beñat Gartzia Arruabarrena <bgartzia@redhat.com>
kubevirt-prow
Bot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configures the MTU on the vdpa device if it is advertised in the network status.
Note that mtu configuration of vdpa devices is not supported in the libvirt version being shipped with the latest upstream KubeVirt.
This also depends on kubevirt/kubevirt#17845 so please, do not merge, and just refer to this as what it really is: a draft.