chore: rename allowInsideKubewardenNamespace spec field.#1544
Merged
viccuad merged 2 commits intokubewarden:mainfrom Mar 4, 2026
Merged
chore: rename allowInsideKubewardenNamespace spec field.#1544viccuad merged 2 commits intokubewarden:mainfrom
viccuad merged 2 commits intokubewarden:mainfrom
Conversation
In a recent change we added a new configuration field in cluster wide policies. This flag tells the controller not to add the namespace selector that skips evaluation of resources in the controller namespace. However, there is a second layer of security to avoid resource evaluations in some namespace configured in the policy-server. When the controller has the "--always-accept-admission-reviews-on-deployments-namespace" CLI flag enabled, it adds the "KUBEWARDEN_ALWAYS_ACCEPT_ADMISSION_REVIEWS_ON_NAMESPACE" environment variable in the policy server deployment, configuring it to consider any request for that namespace (in this case the controller one) as accepted. This makes the policy configuration have no effect. To fix this, this commit adds a new value field in the kubewarden-controller helm chart to allow cluster administrators to disable this CLI flag. Therefore, they would be able to run policies in the Kubewarden namespace. Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
github-project-automation
Bot
moved this to Pending review
in Kubewarden Admission Controller
This commit renames the recent added spec field called allowInsideKubewardenNamespace into allowInsideAdmissionControllerNamespace. This is done to reflect that Kubewarden now has more then the admission controller. Therefore, the previous field name can be misleading. The new name make clear that the configuration is related to the admission controller component from the Kubewarden ecosystem. Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1544 +/- ##
==========================================
- Coverage 80.03% 75.09% -4.94%
==========================================
Files 127 170 +43
Lines 16570 21059 +4489
==========================================
+ Hits 13262 15815 +2553
- Misses 3308 5030 +1722
- Partials 0 214 +214
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
flavio
approved these changes
Mar 4, 2026
viccuad
approved these changes
Mar 4, 2026
github-project-automation
Bot
moved this from Pending review
to Done
in Kubewarden Admission Controller
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit renames the recent added spec field called
allowInsideKubewardenNamespaceintoallowInsideAdmissionControllerNamespace. This is done to reflect that Kubewarden now has more then the admission controller. Therefore, the previous field name can be misleading. The new name make clear that the configuration is related to the admission controller component from the Kubewarden ecosystem.This is build on top of #1542. Thus, that PR should be merged before.