fix(ci): install kwctl version from Github Action.#1662
Conversation
Updates the e2e-tests.yml to install the default version from the kwctl-installer Github action. We cannot use "latest" as version now because it's necessary to verify the signature of binary using cosign and that require the actual version that trigged the release CI job. Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
github-project-automation
Bot
moved this to Pending review
in Kubewarden Admission Controller
There was a problem hiding this comment.
Pull request overview
Updates the end-to-end GitHub Actions workflow to rely on the kwctl-installer action’s default kwctl version (instead of explicitly requesting latest), aligning with the requirement to use a concrete version for signature verification.
Changes:
- Removed the
kwctl-version: latestinput from thekwctl-installerstep so the action chooses its default version.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1662 +/- ##
==========================================
+ Coverage 80.43% 80.44% +0.01%
==========================================
Files 127 127
Lines 16411 16411
==========================================
+ Hits 13200 13202 +2
+ Misses 3211 3209 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
We need -rc versions in tests, I will need to find different way if we remove this. |
viccuad
left a comment
viccuad
left a comment
There was a problem hiding this comment.
I'm Ok merging this for it to work for now, but my vote definitely goes for scheduling the work on kwctl-installer action to support latest (see the other PR).
github-project-automation
Bot
moved this from Pending review
to Done
in Kubewarden Admission Controller
Description
Updates the e2e-tests.yml to install the default version from the kwctl-installer Github action. We cannot use "latest" as version now because it's necessary to verify the signature of binary using cosign and that require the actual version that trigger the release CI job.
Related to kubewarden/github-actions#290