Skip to content

fix: shorten cluster name to fit into 32 chars limit#1669

Merged
jvanz merged 1 commit intokubewarden:mainfrom
kravciak:shortname
Apr 16, 2026
Merged

fix: shorten cluster name to fit into 32 chars limit#1669
jvanz merged 1 commit intokubewarden:mainfrom
kravciak:shortname

Conversation

@kravciak
Copy link
Copy Markdown
Contributor

Description

k3d has limit of 32 characters for cluster name.
This variable is not used for debugging, we can switch to shorter / less readable name.

FATA[0000] Failed Cluster Configuration Validation:  provided cluster name 'kubewarden-kubewarden-controller-private' does not match requirements: Cluster name must be <= 32 characters, but has 40

@kravciak kravciak self-assigned this Apr 16, 2026
@kravciak kravciak requested a review from a team as a code owner April 16, 2026 12:16
Copilot AI review requested due to automatic review settings April 16, 2026 12:16
FATA[0000] Failed Cluster Configuration Validation:  provided cluster name 'kubewarden-kubewarden-controller-private' does not match requirements: Cluster name must be <= 32 characters, but has 40

Signed-off-by: Martin Kravec <kravciak@gmail.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the k3d cluster name used by the E2E GitHub Actions workflow to avoid k3d’s 32-character cluster name limit, preventing cluster creation failures in CI.

Changes:

  • Update K3D_CLUSTER_NAME to use ${{ github.run_id }} instead of the repository name component to shorten the generated cluster name.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/e2e-tests.yml
Copy link
Copy Markdown
Member

@viccuad viccuad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jvanz jvanz merged commit c6ba0b1 into kubewarden:main Apr 16, 2026
28 checks passed
@github-project-automation github-project-automation Bot moved this from Pending review to Done in Kubewarden Admission Controller Apr 16, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.40%. Comparing base (89d5460) to head (2905189).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1669      +/-   ##
==========================================
- Coverage   80.43%   80.40%   -0.03%     
==========================================
  Files         127      127              
  Lines       16411    16411              
==========================================
- Hits        13200    13196       -4     
- Misses       3211     3215       +4     
Flag Coverage Δ
rust-tests 80.40% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

4 participants