Skip to content

Drop Go updatecli policy#1691

Open
AkashKumar7902 wants to merge 1 commit intokubewarden:mainfrom
AkashKumar7902:issue-1639-drop-go-updatecli
Open

Drop Go updatecli policy#1691
AkashKumar7902 wants to merge 1 commit intokubewarden:mainfrom
AkashKumar7902:issue-1639-drop-go-updatecli

Conversation

@AkashKumar7902
Copy link
Copy Markdown

Summary

  • remove the Go-version Updatecli policy from the weekly dependency compose job
  • delete the unused updatecli/updatecli.d/go.yaml policy
  • update the workflow name and Updatecli docs to describe the remaining dependency updates

Fixes #1639

Testing

  • rg -n 'go\\.yaml|Update Go version|Golang version|update Golang|golang/version|Go version in go\.mod' updatecli .github || true\n- yq e . updatecli/update-deps.yaml >/dev/null\n- yq e . .github/workflows/update-dependencies.yaml >/dev/null\n- git diff --check\n\nupdatecli and actionlint are not installed in my local environment.

Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the Go-version Updatecli policy from the weekly dependency update compose job, and updates documentation/workflow labeling to reflect the remaining automated dependency updates.

Changes:

  • Delete the unused updatecli/updatecli.d/go.yaml policy and remove it from the composed updatecli/update-deps.yaml.
  • Update Updatecli developer docs to no longer list Go version updates as part of the weekly workflow.
  • Rename the GitHub Actions job label to reflect the remaining update targets (Rust toolchain, chart deps, Hauler manifest).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
updatecli/updatecli.d/go.yaml Deletes the Go Updatecli policy.
updatecli/update-deps.yaml Removes the Go policy from the composed weekly dependency-update pipeline and updates the pipeline name.
updatecli/DEVELOPING.md Updates the “Weekly Dependency Updates” documentation to remove Go and list remaining updates.
.github/workflows/update-dependencies.yaml Updates the job display name to match the remaining dependency updates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 1 to 6
policies:
- name: Update Go version, Rust toolchain, Helm chart dependencies and Hauler manifest
- name: Update Rust toolchain, Helm chart dependencies and Hauler manifest
config:
- ./updatecli.d/go.yaml
- ./updatecli.d/update-rust-toolchain.yaml
- ./updatecli.d/update-chart-deps.yaml
- ./updatecli.d/update-hauler-manifest.yaml
Copy link

Copilot AI Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description says this “Fixes #1639”, but #1639 describes adjusting the Go Updatecli policy to preserve container image SHAs when bumping Go versions. This change removes the Go Updatecli policy entirely, so it doesn’t address the issue as described. Consider removing the “Fixes #1639” reference or updating the issue/description to reflect that the Go auto-update is intentionally being dropped instead of fixed.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending review

Development

Successfully merging this pull request may close these issues.

updatecli script should update container image SHA

2 participants