feat: Unified Kubewarden admission controller Helm chart#54
feat: Unified Kubewarden admission controller Helm chart#54jvanz wants to merge 1 commit intokubewarden:mainfrom
Conversation
github-project-automation
Bot
moved this to Pending review
in Kubewarden Admission Controller
|
We (@kubewarden/kubewarden-developers ) discussed this RFC in our daily call. There is a communication issue from what I understood from the issue that originates this document. From the issue, I understood that we would like to avoid controller changes. However, we all agree now that the best approach is to use the controller to handle the creation of the Kubewarden default resources. Therefore, I'll update the document to reflect that. |
|
I'm moving this to the blocked column because I need to work in another issue that we would like to add in the controller for the next release. I'll come back to this after that. |
|
@kubewarden/kubewarden-developers I think you can review once more. |
Adds a proposal of how to merge all the Kubewarden admissions controller Helm charts (kubewarden-crds, kubewarden-controller and kubewarden-defaults) into a single Helm chart. This document is a compilation of the discussions from the issue about this desired of unification of the Helm charts. Assisted-by: Github copilot Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
There was a problem hiding this comment.
I like the design. I think, unrelated with this RFC, I'll create an issue to change how we currently handle the deletion of a Policy Server.
I think we should not delete all the policies that are scheduled on it. We should leave them pending.
Given this RFC is probably going to be managed as part of the 1.37 release (we just released 1.35), I think it would be nice to have this change land as part of 1.36.
Update: I've created kubewarden/adm-controller#1700
| **Helm templates do the rendering.** All values (`{{ .Values.* }}`) are | ||
| resolved at Helm template time. The controller receives fully-formed YAML and | ||
| does not need to understand Helm values or custom configuration schemas. |
There was a problem hiding this comment.
I was initially skeptical about this approach, but I think it's a good compromise. I like it, since it keeps the boilerplate to the minimum inside of the Go codebase.
3 participants
Description
Adds a proposal of how to merge all the Kubewarden admissions controller Helm charts (kubewarden-crds, kubewarden-controller and kubewarden-defaults) into a single Helm chart.
This document is a compilation of the discussions from the issue about this desired of unification of the Helm charts.