Skip to content

chore(helm): add nameOverride and fullnameOverride value placeholders#1095

Merged
flavio merged 2 commits intokubewarden:mainfrom
fabriziosestito:chore/add-nameOverride-fullnameOverride-to-values
May 5, 2026
Merged

chore(helm): add nameOverride and fullnameOverride value placeholders#1095
flavio merged 2 commits intokubewarden:mainfrom
fabriziosestito:chore/add-nameOverride-fullnameOverride-to-values

Conversation

@fabriziosestito
Copy link
Copy Markdown
Collaborator

Description

Add nameOverride and fullnameOverride value placeholders to values.yaml.

Copilot AI review requested due to automatic review settings May 5, 2026 07:52
@fabriziosestito fabriziosestito requested a review from a team as a code owner May 5, 2026 07:52
@github-project-automation github-project-automation Bot moved this to Pending Review in SBOMscanner May 5, 2026
@fabriziosestito fabriziosestito self-assigned this May 5, 2026
@fabriziosestito fabriziosestito added this to the v0.12.0 milestone May 5, 2026
@fabriziosestito fabriziosestito modified the milestones: v0.12.0, v0.11.0 May 5, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Helm chart value placeholders for controlling generated resource naming, aligning values.yaml with existing helper template support for nameOverride/fullnameOverride.

Changes:

  • Introduce nameOverride and fullnameOverride keys in charts/sbomscanner/values.yaml with explanatory comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread charts/sbomscanner/values.yaml Outdated
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
@fabriziosestito fabriziosestito force-pushed the chore/add-nameOverride-fullnameOverride-to-values branch from 6a25380 to 8147e09 Compare May 5, 2026 08:01
flavio
flavio previously approved these changes May 5, 2026
@flavio flavio enabled auto-merge May 5, 2026 08:18
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
@flavio flavio merged commit 76f9558 into kubewarden:main May 5, 2026
11 checks passed
@github-project-automation github-project-automation Bot moved this from Pending Review to Done in SBOMscanner May 5, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.46%. Comparing base (da05923) to head (b5d1d11).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1095   +/-   ##
=======================================
  Coverage   53.46%   53.46%           
=======================================
  Files          61       61           
  Lines        5323     5323           
=======================================
  Hits         2846     2846           
  Misses       2081     2081           
  Partials      396      396           
Flag Coverage Δ
unit-tests 53.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants