docs: update nodescan rfc#1207
Open
alegrey91 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Node Scan RFC to reflect the latest NodeScanConfiguration/NodeScanJob workflow and lifecycle semantics requested in #1206, clarifying how periodic vs. immediate scans are triggered and how resources are garbage-collected.
Changes:
- Makes
scanIntervalexplicitly mandatory and framesNodeScanConfigurationas the periodic scan scheduler. - Documents an immediate-scan trigger via
force-node-scan: "true"annotation with automatic removal after completion. - Updates the RFC to reflect inverted ownership/GC semantics:
NodeScanConfigurationowns jobs/SBOMs (Kubernetes GC), while node deletion requires controller-driven cleanup.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1207 +/- ##
==========================================
- Coverage 53.44% 49.83% -3.61%
==========================================
Files 61 77 +16
Lines 5340 6479 +1139
==========================================
+ Hits 2854 3229 +375
- Misses 2088 2794 +706
- Partials 398 456 +58
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
alegrey91
force-pushed
the
docs/update-nodescan-rfc
branch
from
9c7a1d5 to
1dc4a76
Compare
Signed-off-by: Alessio Greggi <alessio.greggi@suse.com>
alegrey91
force-pushed
the
docs/update-nodescan-rfc
branch
from
1dc4a76 to
015cec9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #1206
Test
To test this pull request, you can run the following commands:
Additional Information
Tradeoff
Potential improvement
Checklist