test(controller): cover remaining indexer functions#1236
Open
fabriziosestito wants to merge 1 commit into
Open
test(controller): cover remaining indexer functions#1236fabriziosestito wants to merge 1 commit into
fabriziosestito wants to merge 1 commit into
Conversation
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the controller indexer test suite to cover the remaining indexer functions and key-generation helpers used by SetupIndexer, ensuring field-index-backed list queries and index key formats are exercised by tests.
Changes:
- Extend the
SetupIndexerintegration-style test to validate the NodeScanJob (spec.nodeName) and NodeSBOM (nodeMetadata.name) field indexes by listing with field selectors. - Add unit tests for
indexNodeSBOMByNodeNameto verify correct key extraction and non-target object behavior. - Add unit tests for index key helper functions (
imageMetadataIndexKey,nodeMetadataIndexKey,imageRefIndexKey) including empty-field edge cases.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1236 +/- ##
==========================================
- Coverage 53.44% 50.05% -3.40%
==========================================
Files 61 77 +16
Lines 5340 6479 +1139
==========================================
+ Hits 2854 3243 +389
- Misses 2088 2781 +693
- Partials 398 455 +57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cover remaining indexer functions with tests