Skip to content

feat(cpu): enable cpu burst support#1013

Merged
xu282934741 merged 7 commits intokubewharf:mainfrom
JustinChengLZ:dev/support-cpu-burst
Jan 5, 2026
Merged

feat(cpu): enable cpu burst support#1013
xu282934741 merged 7 commits intokubewharf:mainfrom
JustinChengLZ:dev/support-cpu-burst

Conversation

@JustinChengLZ
Copy link
Copy Markdown
Collaborator

@JustinChengLZ JustinChengLZ commented Nov 6, 2025

What type of PR is this?

  • Enable setting of CPU burst values in pods
  • Calculation of cpu burst values from cpu quota and percentage
  • Default cpu burst values can be configured through kcc
  • Adding unit tests

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 58.64198% with 67 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.48%. Comparing base (62f5d0c) to head (7efab29).
⚠️ Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
.../qrm-plugins/cpu/dynamicpolicy/cpuburst/manager.go 50.66% 28 Missing and 9 partials ⚠️
...-plugins/cpu/dynamicpolicy/policy_async_handler.go 0.00% 8 Missing ⚠️
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 14.28% 5 Missing and 1 partial ⚠️
pkg/util/cgroup/manager/v1/fs_linux.go 0.00% 4 Missing and 1 partial ⚠️
pkg/util/cgroup/manager/v2/fs_linux.go 0.00% 4 Missing and 1 partial ⚠️
cmd/katalyst-agent/app/options/qrm/cpu_plugin.go 40.00% 3 Missing ⚠️
pkg/agent/qrm-plugins/cpu/util/util.go 91.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1013      +/-   ##
==========================================
+ Coverage   60.41%   60.48%   +0.07%     
==========================================
  Files         697      698       +1     
  Lines       66193    66360     +167     
==========================================
+ Hits        39990    40138     +148     
- Misses      21665    21677      +12     
- Partials     4538     4545       +7     
Flag Coverage Δ
unittest 60.48% <58.64%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JustinChengLZ JustinChengLZ force-pushed the dev/support-cpu-burst branch 8 times, most recently from 9b889b3 to c1a6ec9 Compare November 13, 2025 11:44
@JustinChengLZ JustinChengLZ force-pushed the dev/support-cpu-burst branch 5 times, most recently from 643de20 to d5bd99e Compare November 17, 2025 09:18
Comment thread pkg/agent/qrm-plugins/cpu/dynamicpolicy/cpuburst/manager.go Outdated
Comment thread pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go Outdated
Comment thread cmd/katalyst-agent/app/options/qrm/cpu_plugin.go Outdated
@JustinChengLZ JustinChengLZ added the workflow/need-review review: test succeeded, need to review label Nov 18, 2025
@JustinChengLZ JustinChengLZ changed the title (WIP) feat(cpu): enable cpu burst support feat(cpu): enable cpu burst support Nov 18, 2025
Comment thread pkg/util/qos/cpu_enhancement.go Outdated
Comment thread pkg/util/cgroup/common/types.go Outdated
Comment thread pkg/util/cgroup/manager/v1/fs_linux.go Outdated
Comment thread pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go Outdated
Comment thread pkg/agent/qrm-plugins/cpu/dynamicpolicy/cpuburst/manager.go Outdated
Comment thread pkg/agent/qrm-plugins/cpu/dynamicpolicy/cpuburst/manager.go Outdated
Comment thread pkg/agent/qrm-plugins/cpu/dynamicpolicy/cpuburst/manager.go Outdated
@JustinChengLZ JustinChengLZ force-pushed the dev/support-cpu-burst branch 2 times, most recently from ab2e513 to 2f0686b Compare November 26, 2025 02:49
@JustinChengLZ JustinChengLZ force-pushed the dev/support-cpu-burst branch 2 times, most recently from 91980bd to 701a600 Compare December 4, 2025 02:53
feat(cpu): enable cpu burst support

feat(cpu): enable cpu burst support

feat(cpu): enable cpu burst support

feat(cpu): enable cpu burst support
chore: add unit tests

chore: add unit tests
feat: implement aqc kcc control for default cpu burst values

feat: implement aqc kcc control for default cpu burst values

feat: implement aqc kcc control for default cpu burst values
…urst to 0

feat: ensure dedicated cores with no cpu burst policy still set cpu burst to 0

feat: ensure dedicated cores with no cpu burst policy still set cpu burst to 0
fix: PR comments
@JustinChengLZ JustinChengLZ force-pushed the dev/support-cpu-burst branch 3 times, most recently from 5010e0f to 640b52a Compare December 29, 2025 09:14
@JustinChengLZ JustinChengLZ force-pushed the dev/support-cpu-burst branch from 640b52a to 7efab29 Compare January 5, 2026 12:20
@xu282934741 xu282934741 merged commit b39c1e9 into kubewharf:main Jan 5, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

workflow/need-review review: test succeeded, need to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants