Skip to content

fix(network_linux): fix umount failure#1015

Merged
luomingmeng merged 1 commit intokubewharf:mainfrom
zhanghaoyu1986:dev/fix-umount-failure
Nov 10, 2025
Merged

fix(network_linux): fix umount failure#1015
luomingmeng merged 1 commit intokubewharf:mainfrom
zhanghaoyu1986:dev/fix-umount-failure

Conversation

@zhanghaoyu1986
Copy link
Copy Markdown
Collaborator

@zhanghaoyu1986 zhanghaoyu1986 commented Nov 10, 2025

unmount failed in the network namespace (netns) because the netns temporary mount directory is /tmp/net_ns_sysfs, and tce_agent occasionally traverses the /tmp directory.

What type of PR is this?

Bug fixes

Which issue(s) this PR fixes:

unmount failed in the network namespace (netns) because the netns
temporary mount directory is /tmp/net_ns_sysfs, and tce_agent
occasionally traverses the /tmp directory.
So we mount sysfs to a special dir(/qrm_tmp_sys/net_ns_sysfs) instead of /tmp/net_ns_sysfs, and retried 3 times after umount failed.

@zhanghaoyu1986 zhanghaoyu1986 added the workflow/need-review review: test succeeded, need to review label Nov 10, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 10, 2025

Codecov Report

❌ Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.70%. Comparing base (5eecdc5) to head (72d722a).

Files with missing lines Patch % Lines
pkg/util/machine/network_linux.go 75.00% 1 Missing and 2 partials ⚠️
...amicpolicy/irqtuner/controller/controller_linux.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1015      +/-   ##
==========================================
- Coverage   59.72%   59.70%   -0.03%     
==========================================
  Files         682      682              
  Lines       64009    64021      +12     
==========================================
- Hits        38231    38221      -10     
- Misses      21376    21396      +20     
- Partials     4402     4404       +2     
Flag Coverage Δ
unittest 59.70% <69.23%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread pkg/util/machine/network_linux.go
Comment thread pkg/util/machine/network_linux.go Outdated
@zhanghaoyu1986 zhanghaoyu1986 force-pushed the dev/fix-umount-failure branch 10 times, most recently from 8ec0d16 to ef96c3c Compare November 10, 2025 06:28
JulyWindK
JulyWindK previously approved these changes Nov 10, 2025
Comment thread pkg/util/machine/network_linux.go
@zhanghaoyu1986 zhanghaoyu1986 force-pushed the dev/fix-umount-failure branch 2 times, most recently from 6afb75b to ba2bb6c Compare November 10, 2025 07:26
unmount failed in the network namespace (netns) because the netns
temporary mount directory is /tmp/net_ns_sysfs, and tce_agent
occasionally traverses the /tmp directory.

Signed-off-by: 张浩宇 <zhanghaoyu.zhy@bytedance.com>
xu282934741
xu282934741 previously approved these changes Nov 10, 2025
@luomingmeng luomingmeng merged commit d77bd6f into kubewharf:main Nov 10, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

workflow/need-review review: test succeeded, need to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants