feat(advisor): apply cpu headroom discount when power level is present #1034
+569
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-w-chen
requested review from
cheney-lin,
luomingmeng,
sun-yuliang,
waynepeking348 and
xu282934741
as code owners
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1034 +/- ##
==========================================
+ Coverage 59.86% 60.05% +0.18%
==========================================
Files 689 692 +3
Lines 65082 65230 +148
==========================================
+ Hits 38964 39173 +209
+ Misses 21657 21602 -55
+ Partials 4461 4455 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
h-w-chen
force-pushed
the
dev/pap-discounted-cpu-headroom
branch
2 times, most recently
from
8474476 to
abe7d94
Compare
h-w-chen
force-pushed
the
dev/pap-discounted-cpu-headroom
branch
2 times, most recently
from
1f97144 to
cf4b24d
Compare
h-w-chen
changed the title
h-w-chen
changed the title
JulyWindK
reviewed
Jan 13, 2026
| numaHeadrooms[numa] = applyDiscount(numaHeadrooms[numa], currentDiscount) | ||
| } | ||
| if err != nil || currentDiscount >= 1.0 { | ||
| return headroom, numaHeadrooms, err |
Collaborator
There was a problem hiding this comment.
Does this error need to be encapsulated? When err is empty and currentDiscount>=1.0, is it expected that err will be empty?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Features
What this PR does / why we need it:
This PR allows power-ware plugin to enable reclaimed cpu headroom discount when the node's power level is of p1/p2/p3.
To ensure the power-aware plugin enabling to happen prior qos-aware cpu resource advisor being called to GetHeadroom, Init phase is put with cpu sub resource advisor up to qos-aware plugin.