Skip to content

feat: implement rdma associated device allocation logic#1083

Open
JustinChengLZ wants to merge 5 commits intokubewharf:mainfrom
JustinChengLZ:dev/support-rdma-plugins
Open

feat: implement rdma associated device allocation logic#1083
JustinChengLZ wants to merge 5 commits intokubewharf:mainfrom
JustinChengLZ:dev/support-rdma-plugins

Conversation

@JustinChengLZ
Copy link
Copy Markdown
Collaborator

@JustinChengLZ JustinChengLZ commented Mar 4, 2026

What type of PR is this?

  • implement associated device rdma allocation logic
  • refactor code to include a accompanyResource strategy

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 78.70130% with 82 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.57%. Comparing base (edc1181) to head (c52253e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nt/qrm-plugins/gpu/customdeviceplugin/rdma/rdma.go 79.43% 15 Missing and 7 partials ⚠️
...tegy/allocate/strategies/accompanyresource/bind.go 79.04% 16 Missing and 6 partials ⚠️
...-plugins/gpu/strategy/allocate/manager/defaults.go 21.05% 10 Missing and 5 partials ⚠️
...gent/qrm-plugins/gpu/customdeviceplugin/gpu/gpu.go 16.66% 5 Missing ⚠️
...rm-plugins/gpu/resourceplugin/gpumemory/gpu_mem.go 28.57% 5 Missing ⚠️
...u/strategy/allocate/strategies/canonical/filter.go 33.33% 2 Missing and 2 partials ⚠️
...trategy/allocate/strategies/deviceaffinity/bind.go 40.00% 2 Missing and 1 partial ⚠️
...nt/qrm-plugins/gpu/baseplugin/reporter/reporter.go 75.00% 1 Missing and 1 partial ⚠️
pkg/agent/qrm-plugins/gpu/staticpolicy/policy.go 33.33% 2 Missing ⚠️
...pu/strategy/allocate/strategies/gpu_memory/sort.go 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1083      +/-   ##
==========================================
+ Coverage   61.47%   61.57%   +0.10%     
==========================================
  Files         783      788       +5     
  Lines       73167    73472     +305     
==========================================
+ Hits        44977    45242     +265     
- Misses      23176    23192      +16     
- Partials     5014     5038      +24     
Flag Coverage Δ
unittest 61.57% <78.70%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JustinChengLZ JustinChengLZ force-pushed the dev/support-rdma-plugins branch 2 times, most recently from ca639ed to 343e74a Compare March 6, 2026 10:42
@JustinChengLZ JustinChengLZ force-pushed the dev/support-rdma-plugins branch 5 times, most recently from 8899473 to d8dd2ef Compare March 18, 2026 11:32
@JustinChengLZ JustinChengLZ force-pushed the dev/support-rdma-plugins branch 18 times, most recently from 5affe39 to ba0a336 Compare March 31, 2026 08:26
@JustinChengLZ JustinChengLZ force-pushed the dev/support-rdma-plugins branch 3 times, most recently from f2a18c6 to 7c06080 Compare April 6, 2026 03:24
@JustinChengLZ JustinChengLZ force-pushed the dev/support-rdma-plugins branch 2 times, most recently from 16ade1e to a2b27c9 Compare April 7, 2026 03:16
@JustinChengLZ JustinChengLZ force-pushed the dev/support-rdma-plugins branch from a2b27c9 to c52253e Compare April 7, 2026 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant