Skip to content

feat(*): support user memory watermark#1086

Open
JulyWindK wants to merge 3 commits intokubewharf:mainfrom
JulyWindK:dev/kfx-support-user-mem-watermark
Open

feat(*): support user memory watermark#1086
JulyWindK wants to merge 3 commits intokubewharf:mainfrom
JulyWindK:dev/kfx-support-user-mem-watermark

Conversation

@JulyWindK
Copy link
Copy Markdown
Collaborator

@JulyWindK JulyWindK commented Mar 9, 2026

What type of PR is this?

Features/

What this PR does / why we need it:

Implementing a memory watermark for user-space containers effectively prevents memory from becoming too full, which could lead to memory stall. It can also be used to alleviate the JBD hung problem that occurs probabilistically during memory reclamation when container memory is too full and there is a large amount of dirty cache.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@JulyWindK JulyWindK force-pushed the dev/kfx-support-user-mem-watermark branch from b47922f to 5852f0b Compare March 9, 2026 06:14
@JulyWindK JulyWindK force-pushed the dev/kfx-support-user-mem-watermark branch 3 times, most recently from d15ded0 to aa5b388 Compare March 17, 2026 11:24
@JulyWindK JulyWindK force-pushed the dev/kfx-support-user-mem-watermark branch 7 times, most recently from 178dc4a to 72d6f63 Compare April 8, 2026 07:15
@JulyWindK JulyWindK force-pushed the dev/kfx-support-user-mem-watermark branch from 72d6f63 to 999acef Compare April 8, 2026 08:47
@JulyWindK JulyWindK closed this Apr 8, 2026
@JulyWindK JulyWindK deleted the dev/kfx-support-user-mem-watermark branch April 8, 2026 11:17
@JulyWindK JulyWindK restored the dev/kfx-support-user-mem-watermark branch April 8, 2026 11:18
@JulyWindK JulyWindK reopened this Apr 8, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

❌ Patch coverage is 50.75862% with 357 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.44%. Comparing base (95c2c56) to head (554661d).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...ns/memory/dynamicpolicy/userwatermark/reclaimer.go 43.25% 182 Missing and 20 partials ⚠️
...gins/memory/dynamicpolicy/userwatermark/manager.go 67.92% 27 Missing and 7 partials ⚠️
pkg/util/cgroup/manager/v1/fs_linux.go 0.00% 30 Missing ⚠️
pkg/util/cgroup/manager/v2/fs_linux.go 0.00% 30 Missing ⚠️
...rwatermarkdefault/user_watermark_default_config.go 51.85% 26 Missing ⚠️
...s/memory/dynamicpolicy/userwatermark/calculator.go 76.19% 9 Missing and 1 partial ⚠️
...tions/dynamic/userwatermark/user_watermark_base.go 50.00% 9 Missing ⚠️
...g/agent/qrm-plugins/memory/dynamicpolicy/policy.go 25.00% 4 Missing and 2 partials ⚠️
pkg/util/cgroup/manager/cgroup.go 0.00% 5 Missing ⚠️
...md/katalyst-agent/app/options/qrm/memory_plugin.go 50.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1086      +/-   ##
==========================================
- Coverage   61.46%   61.44%   -0.03%     
==========================================
  Files         783      789       +6     
  Lines       72974    73906     +932     
==========================================
+ Hits        44853    45411     +558     
- Misses      23139    23458     +319     
- Partials     4982     5037      +55     
Flag Coverage Δ
unittest 61.44% <50.75%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JulyWindK JulyWindK force-pushed the dev/kfx-support-user-mem-watermark branch from 1725f32 to 62fc12e Compare April 9, 2026 06:52
@JulyWindK JulyWindK force-pushed the dev/kfx-support-user-mem-watermark branch from 62fc12e to 554661d Compare April 9, 2026 07:08
@JulyWindK JulyWindK changed the title [WIP]feat(*): support user memory watermark feat(*): support user memory watermark Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant