Skip to content

fix(state): consider state checkpoint path is not a file#1100

Open
JustinChengLZ wants to merge 2 commits intokubewharf:mainfrom
JustinChengLZ:fix/delete-state-directory
Open

fix(state): consider state checkpoint path is not a file#1100
JustinChengLZ wants to merge 2 commits intokubewharf:mainfrom
JustinChengLZ:fix/delete-state-directory

Conversation

@JustinChengLZ
Copy link
Copy Markdown
Collaborator

What type of PR is this?

  • Sometimes, we end up reading a directory which will cause a panic. This is to handle that case

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 64.28571% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.90%. Comparing base (7bf6456) to head (659d6c0).
⚠️ Report is 128 commits behind head on main.

Files with missing lines Patch % Lines
pkg/util/general/file.go 70.00% 3 Missing and 3 partials ⚠️
...customcheckpointmanager/customcheckpointmanager.go 50.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1100      +/-   ##
==========================================
+ Coverage   60.85%   60.90%   +0.04%     
==========================================
  Files         739      739              
  Lines       69780    69806      +26     
==========================================
+ Hits        42467    42514      +47     
+ Misses      22549    22515      -34     
- Partials     4764     4777      +13     
Flag Coverage Δ
unittest 60.90% <64.28%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant