feat(gpu): start device topology registry in base plugin#1108
Open
luomingmeng wants to merge 2 commits intokubewharf:mainfrom
Open
feat(gpu): start device topology registry in base plugin#1108luomingmeng wants to merge 2 commits intokubewharf:mainfrom
luomingmeng wants to merge 2 commits intokubewharf:mainfrom
Conversation
Add missing call to run device topology registry in base plugin's Run method and ensure it's started in StaticPolicy's Start method
Check for nil return value from PickLatestDeviceTopology and return appropriate error to prevent potential nil pointer dereference
JustinChengLZ
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enhancements
What this PR does / why we need it:
Add missing call to run device topology registry in base plugin's Run method and ensure it's started in StaticPolicy's Start method
Which issue(s) this PR fixes:
Special notes for your reviewer: