Skip to content

enhance(qrm): mem bandwidth throttler qrm plugin supports multiple resctrl groups sharing same priority #1111

Open
h-w-chen wants to merge 10 commits intokubewharf:mainfrom
h-w-chen:dev/mbm-polify-db-uce
Open

enhance(qrm): mem bandwidth throttler qrm plugin supports multiple resctrl groups sharing same priority #1111
h-w-chen wants to merge 10 commits intokubewharf:mainfrom
h-w-chen:dev/mbm-polify-db-uce

Conversation

@h-w-chen
Copy link
Copy Markdown
Collaborator

@h-w-chen h-w-chen commented Mar 27, 2026

What type of PR is this?

Enhancements

What this PR does / why we need it:

traditional mem bandwidth policy is able to throttle fixed resctrl groups with unique priorities. DB-UCE colocation scenario has dedicated (one of the fixed groups) and machine (not part of fixed groups), both with same priority. This PR adapts to allow extra resctrl groups and multiple groups sharing identical priority.

Special notes for your reviewer:

code has been verified on single node at test cluster

@h-w-chen h-w-chen requested a review from luomingmeng as a code owner March 27, 2026 15:56
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 74.22222% with 58 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.57%. Comparing base (0c304b9) to head (b31c94e).
⚠️ Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
...nt/qrm-plugins/mb/advisor/uniq_priority_advisor.go 56.86% 15 Missing and 7 partials ⚠️
...g/agent/qrm-plugins/mb/advisor/priority_advisor.go 58.69% 17 Missing and 2 partials ⚠️
.../qrm-plugins/mb/advisor/priority/group_priority.go 79.48% 5 Missing and 3 partials ⚠️
pkg/agent/qrm-plugins/mb/policy/plugin.go 0.00% 5 Missing ⚠️
cmd/katalyst-agent/app/options/qrm/mb_plugin.go 33.33% 2 Missing ⚠️
pkg/agent/qrm-plugins/mb/advisor/advisor_helper.go 96.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1111      +/-   ##
==========================================
+ Coverage   61.45%   61.57%   +0.11%     
==========================================
  Files         783      785       +2     
  Lines       72974    73306     +332     
==========================================
+ Hits        44848    45135     +287     
- Misses      23142    23160      +18     
- Partials     4984     5011      +27     
Flag Coverage Δ
unittest 61.57% <74.22%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@h-w-chen h-w-chen force-pushed the dev/mbm-polify-db-uce branch 2 times, most recently from f7942b5 to d45871b Compare March 29, 2026 04:16
@h-w-chen h-w-chen changed the title WIP: DB-UCE 并池内存带宽压制适配 WIP: mem bandwidth throttle adaption for DB-UCE colocation Mar 30, 2026
@h-w-chen h-w-chen force-pushed the dev/mbm-polify-db-uce branch from f07ec01 to 5b51e32 Compare March 30, 2026 20:52
@h-w-chen h-w-chen changed the title WIP: mem bandwidth throttle adaption for DB-UCE colocation enhance(qrm): mem bandwidth throttler qrm plugin adapted to DB-UCE colocation Mar 30, 2026
@h-w-chen h-w-chen added the workflow/need-review review: test succeeded, need to review label Mar 30, 2026
@h-w-chen h-w-chen changed the title enhance(qrm): mem bandwidth throttler qrm plugin adapted to DB-UCE colocation enhance(qrm): mem bandwidth throttler qrm plugin supports multiple resctrl groups sharing same priority Apr 7, 2026
@h-w-chen h-w-chen force-pushed the dev/mbm-polify-db-uce branch from d045cc8 to 1267850 Compare April 7, 2026 06:39
@h-w-chen h-w-chen force-pushed the dev/mbm-polify-db-uce branch from 3eb1105 to b31c94e Compare April 8, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

workflow/need-review review: test succeeded, need to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants