Skip to content

feat(*): add switch to support disabling some reporters#1114

Merged
luomingmeng merged 2 commits intokubewharf:mainfrom
fantastic-hf:dev/reporters
Apr 8, 2026
Merged

feat(*): add switch to support disabling some reporters#1114
luomingmeng merged 2 commits intokubewharf:mainfrom
fantastic-hf:dev/reporters

Conversation

@fantastic-hf
Copy link
Copy Markdown
Contributor

What type of PR is this?

Features: add flags to support disabling some reporters

What this PR does / why we need it:

We hope to deploy katalyst in k8s 1.35 cluster. Some modules are not needed in this case.

Which issue(s) this PR fixes:

None.

Special notes for your reviewer:

None.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 31, 2026

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

❌ Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.56%. Comparing base (95c2c56) to head (bbec2f6).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...talyst-agent/app/options/reporter/reporter_base.go 40.00% 3 Missing ⚠️
pkg/agent/resourcemanager/reporter/manager.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1114      +/-   ##
==========================================
+ Coverage   61.46%   61.56%   +0.09%     
==========================================
  Files         783      783              
  Lines       72974    73177     +203     
==========================================
+ Hits        44853    45049     +196     
+ Misses      23139    23126      -13     
- Partials     4982     5002      +20     
Flag Coverage Δ
unittest 61.56% <45.45%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fantastic-hf fantastic-hf reopened this Apr 7, 2026
@luomingmeng luomingmeng merged commit 7320721 into kubewharf:main Apr 8, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants