Skip to content

feat(health): allow appending of errors only if it has been produced before#1120

Open
JustinChengLZ wants to merge 1 commit intokubewharf:mainfrom
JustinChengLZ:dev/fix-healthcheck-pods-restarting
Open

feat(health): allow appending of errors only if it has been produced before#1120
JustinChengLZ wants to merge 1 commit intokubewharf:mainfrom
JustinChengLZ:dev/fix-healthcheck-pods-restarting

Conversation

@JustinChengLZ
Copy link
Copy Markdown
Collaborator

@JustinChengLZ JustinChengLZ commented Apr 2, 2026

What type of PR is this?

  • Implement a new general class ErrorSecondSightTracker that allows appending of errors only when it has been seen before
  • For health check purposes, we do not want to record transient errors which may affect health check of the agent

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@JustinChengLZ JustinChengLZ force-pushed the dev/fix-healthcheck-pods-restarting branch from e3cb5f0 to 318b5a6 Compare April 2, 2026 08:16
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 62.22222% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.56%. Comparing base (95c2c56) to head (bf52558).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
.../qrm-plugins/cpu/dynamicpolicy/cpuburst/manager.go 0.00% 9 Missing ⚠️
pkg/util/general/error.go 82.35% 4 Missing and 2 partials ⚠️
...m-plugins/memory/handlers/sockmem/sockmem_linux.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1120      +/-   ##
==========================================
+ Coverage   61.46%   61.56%   +0.09%     
==========================================
  Files         783      783              
  Lines       72974    73198     +224     
==========================================
+ Hits        44853    45062     +209     
+ Misses      23139    23135       -4     
- Partials     4982     5001      +19     
Flag Coverage Δ
unittest 61.56% <62.22%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JustinChengLZ JustinChengLZ force-pushed the dev/fix-healthcheck-pods-restarting branch from 318b5a6 to bf52558 Compare April 2, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant