Skip to content

feat(gpu): strict device affinity requirement and refactor#1121

Open
JustinChengLZ wants to merge 2 commits intokubewharf:mainfrom
JustinChengLZ:dev/device-affinity-strong-constraint
Open

feat(gpu): strict device affinity requirement and refactor#1121
JustinChengLZ wants to merge 2 commits intokubewharf:mainfrom
JustinChengLZ:dev/device-affinity-strong-constraint

Conversation

@JustinChengLZ
Copy link
Copy Markdown
Collaborator

What type of PR is this?

  • Strict device affinity requirement
  • Refactor affinity priority into dimensions so that there is only one source of truth

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@JustinChengLZ JustinChengLZ changed the title feat: strict device affinity requirement and refactor feat(gpu): strict device affinity requirement and refactor Apr 6, 2026
@JustinChengLZ JustinChengLZ force-pushed the dev/device-affinity-strong-constraint branch from aa6fce7 to bf2a90f Compare April 6, 2026 11:51
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

❌ Patch coverage is 88.73239% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.57%. Comparing base (edc1181) to head (0d0a140).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pkg/util/machine/device.go 76.00% 3 Missing and 3 partials ⚠️
cmd/katalyst-agent/app/options/qrm/gpu_plugin.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1121      +/-   ##
==========================================
+ Coverage   61.47%   61.57%   +0.10%     
==========================================
  Files         783      783              
  Lines       73167    73206      +39     
==========================================
+ Hits        44977    45079     +102     
+ Misses      23176    23125      -51     
+ Partials     5014     5002      -12     
Flag Coverage Δ
unittest 61.57% <88.73%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JustinChengLZ JustinChengLZ changed the title feat(gpu): strict device affinity requirement and refactor [WIP] feat(gpu): strict device affinity requirement and refactor Apr 7, 2026
@JustinChengLZ JustinChengLZ force-pushed the dev/device-affinity-strong-constraint branch from bf2a90f to 990e1ea Compare April 8, 2026 11:35
@JustinChengLZ JustinChengLZ changed the title [WIP] feat(gpu): strict device affinity requirement and refactor feat(gpu): strict device affinity requirement and refactor Apr 8, 2026
@JustinChengLZ JustinChengLZ force-pushed the dev/device-affinity-strong-constraint branch from 990e1ea to eba26f6 Compare April 8, 2026 12:01
@JustinChengLZ JustinChengLZ force-pushed the dev/device-affinity-strong-constraint branch from eba26f6 to 9a39f17 Compare April 9, 2026 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant