Skip to content

refactor(irq-tuning): handle known failure of get GetNicQueue2Irq#1122

Open
zhanghaoyu1986 wants to merge 2 commits intokubewharf:mainfrom
zhanghaoyu1986:dev/fix-nic-irq-queue-mapping
Open

refactor(irq-tuning): handle known failure of get GetNicQueue2Irq#1122
zhanghaoyu1986 wants to merge 2 commits intokubewharf:mainfrom
zhanghaoyu1986:dev/fix-nic-irq-queue-mapping

Conversation

@zhanghaoyu1986
Copy link
Copy Markdown
Collaborator

handle known failure of get GetNicQueue2Irq

What type of PR is this?

Bug fixes

What this PR does / why we need it:

fix nic queue<->irq mapping

@zhanghaoyu1986 zhanghaoyu1986 added the workflow/need-review review: test succeeded, need to review label Apr 7, 2026
@zhanghaoyu1986 zhanghaoyu1986 force-pushed the dev/fix-nic-irq-queue-mapping branch from ba40739 to efba57d Compare April 7, 2026 11:33
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

❌ Patch coverage is 22.98851% with 67 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.48%. Comparing base (07dcf1d) to head (41fb16b).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
pkg/util/machine/network_linux.go 25.33% 52 Missing and 4 partials ⚠️
...amicpolicy/irqtuner/controller/controller_linux.go 0.00% 11 Missing ⚠️

❌ Your patch check has failed because the patch coverage (22.98%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1122      +/-   ##
==========================================
+ Coverage   61.44%   61.48%   +0.04%     
==========================================
  Files         783      783              
  Lines       73163    73239      +76     
==========================================
+ Hits        44952    45031      +79     
+ Misses      23202    23197       -5     
- Partials     5009     5011       +2     
Flag Coverage Δ
unittest 61.48% <22.98%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

handle known failure of get GetNicQueue2Irq

Signed-off-by: 张浩宇 <zhanghaoyu.zhy@bytedance.com>
@zhanghaoyu1986 zhanghaoyu1986 force-pushed the dev/fix-nic-irq-queue-mapping branch from efba57d to ab30791 Compare April 7, 2026 12:04
}
}

if isUnsupportedNicQueue2Irq(nicInfo) {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is recommended to place this logic before the function to terminate meaningless execution early.

support GCP gve nic

Signed-off-by: 张浩宇 <zhanghaoyu.zhy@bytedance.com>
@zhanghaoyu1986 zhanghaoyu1986 force-pushed the dev/fix-nic-irq-queue-mapping branch from cd0781b to 41fb16b Compare April 9, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

workflow/need-review review: test succeeded, need to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants