Skip to content

feat(qrm): support set memory.high to throttle reclaimed_cores#1125

Merged
xu282934741 merged 1 commit intokubewharf:mainfrom
cheney-lin:dev/mem_guard
Apr 13, 2026
Merged

feat(qrm): support set memory.high to throttle reclaimed_cores#1125
xu282934741 merged 1 commit intokubewharf:mainfrom
cheney-lin:dev/mem_guard

Conversation

@cheney-lin
Copy link
Copy Markdown
Member

Breaching the memory.high limit doesn't trigger the OOM killer but throttles the offending cgroup, task will not hold lock when trying reclaim memory, which will not lead to priority inversion and hung task.

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@cheney-lin cheney-lin force-pushed the dev/mem_guard branch 3 times, most recently from 84f4fbf to fef378f Compare April 9, 2026 07:55
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 11, 2026

Codecov Report

❌ Patch coverage is 55.55556% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.57%. Comparing base (f4d9f38) to head (55ffd45).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...in/qosaware/resource/memory/plugin/memory_guard.go 37.50% 9 Missing and 1 partial ⚠️
pkg/util/cgroup/manager/v2/fs_linux.go 0.00% 7 Missing and 1 partial ⚠️
...ins/memory/dynamicpolicy/policy_advisor_handler.go 89.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1125      +/-   ##
==========================================
+ Coverage   61.54%   61.57%   +0.03%     
==========================================
  Files         783      783              
  Lines       73181    73224      +43     
==========================================
+ Hits        45038    45091      +53     
+ Misses      23139    23129      -10     
  Partials     5004     5004              
Flag Coverage Δ
unittest 61.57% <55.55%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Breaching the memory.high limit doesn't trigger the OOM killer but
throttles the offending cgroup, task will not hold lock when trying
reclaim memory, which will not lead to priority inversion and hung task.

Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
@cheney-lin cheney-lin self-assigned this Apr 12, 2026
@cheney-lin cheney-lin added the workflow/need-review review: test succeeded, need to review label Apr 12, 2026
@xu282934741 xu282934741 merged commit 6546378 into kubewharf:main Apr 13, 2026
36 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

workflow/need-review review: test succeeded, need to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants