Skip to content

Conversation

@h-w-chen
Copy link
Collaborator

@h-w-chen h-w-chen commented Jul 2, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@h-w-chen h-w-chen force-pushed the dev/hw-mbm branch 2 times, most recently from a0e1f5f to 44f5168 Compare July 9, 2025 16:32
@codecov
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

❌ Patch coverage is 63.03171% with 478 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.52%. Comparing base (798dc28) to head (200b918).
⚠️ Report is 45 commits behind head on main.

Files with missing lines Patch % Lines
pkg/agent/qrm-plugins/mb/policy/plugin.go 11.00% 86 Missing and 11 partials ⚠️
pkg/agent/qrm-plugins/mb/reader/mb_reader.go 50.83% 38 Missing and 21 partials ⚠️
pkg/agent/qrm-plugins/mb/advisor/domain_advisor.go 57.97% 45 Missing and 13 partials ⚠️
pkg/agent/qrm-plugins/mb/policy/policy.go 0.00% 31 Missing ⚠️
...c/provisioner/malachite/realtime_mb_provisioner.go 45.09% 21 Missing and 7 partials ⚠️
pkg/agent/qrm-plugins/mb/policy/capacity.go 15.62% 25 Missing and 2 partials ⚠️
cmd/katalyst-agent/app/options/qrm/mb_plugin.go 46.66% 24 Missing ⚠️
pkg/agent/qrm-plugins/mb/advisor/advisor_helper.go 75.53% 17 Missing and 6 partials ⚠️
pkg/agent/qrm-plugins/mb/domain/types.go 75.26% 13 Missing and 10 partials ⚠️
...gent/qrm-plugins/mb/allocator/resctrl_allocator.go 67.21% 15 Missing and 5 partials ⚠️
... and 16 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #886      +/-   ##
==========================================
+ Coverage   59.86%   60.52%   +0.65%     
==========================================
  Files         689      726      +37     
  Lines       65082    67484    +2402     
==========================================
+ Hits        38964    40847    +1883     
- Misses      21657    21999     +342     
- Partials     4461     4638     +177     
Flag Coverage Δ
unittest 60.52% <63.03%> (+0.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@h-w-chen h-w-chen force-pushed the dev/hw-mbm branch 4 times, most recently from be628d8 to 9a392fa Compare July 29, 2025 17:59
@h-w-chen h-w-chen force-pushed the dev/hw-mbm branch 5 times, most recently from 07a5afd to abde112 Compare August 6, 2025 16:16
@h-w-chen h-w-chen requested a review from JulyWindK as a code owner August 8, 2025 16:30
@h-w-chen h-w-chen force-pushed the dev/hw-mbm branch 8 times, most recently from 1f0e095 to 266cd75 Compare August 13, 2025 22:51
@h-w-chen h-w-chen force-pushed the dev/hw-mbm branch 6 times, most recently from 1b63851 to 3447706 Compare August 21, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request workflow/need-review review: test succeeded, need to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants