fix(qrm-plugins): improve hint generation logic for best effort allocations #900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luomingmeng
force-pushed
the
dev/refactor-qrm-reclaim-hint-calculate
branch
3 times, most recently
from
d31021e to
952c427
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #900 +/- ##
==========================================
- Coverage 58.46% 58.45% -0.01%
==========================================
Files 670 670
Lines 75920 75911 -9
==========================================
- Hits 44387 44376 -11
+ Misses 27241 27237 -4
- Partials 4292 4298 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
luomingmeng
force-pushed
the
dev/refactor-qrm-reclaim-hint-calculate
branch
from
952c427 to
c6e04d5
Compare
luomingmeng
force-pushed
the
dev/refactor-qrm-reclaim-hint-calculate
branch
from
c6e04d5 to
a94079a
Compare
…ations Skip nodes with negative resources in both memory and CPU plugins Simplify hint generation by removing redundant condition checks Make first hint preferred in CPU plugin for better allocation
…hNUMABindingHintHandler
luomingmeng
force-pushed
the
dev/refactor-qrm-reclaim-hint-calculate
branch
from
a94079a to
c3f3b37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enhancements
What this PR does / why we need it:
Skip nodes with negative resources in both memory and CPU plugins Simplify hint generation by removing redundant condition checks Make first hint preferred in CPU plugin for better allocation
Which issue(s) this PR fixes:
Special notes for your reviewer: